Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up VFS integration before parsing options #9457

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Set up VFS integration before parsing options #9457

merged 1 commit into from
Feb 28, 2022

Conversation

fmoc
Copy link
Contributor

@fmoc fmoc commented Feb 19, 2022

Fixes #9155

@fmoc fmoc requested a review from a team February 19, 2022 15:00
@fmoc fmoc changed the base branch from master to 2.10 February 19, 2022 15:00
TheOneRing
TheOneRing reviewed Feb 21, 2022
View reviewed changes
src/gui/application.cpp Outdated Show resolved Hide resolved
TheOneRing
TheOneRing requested changes Feb 21, 2022
View reviewed changes
Copy link
Member

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⬆️

@fmoc fmoc requested review from TheOneRing and a team February 21, 2022 10:56
TheOneRing
TheOneRing requested changes Feb 21, 2022
View reviewed changes
changelog/unreleased/9155 Outdated Show resolved Hide resolved
@ownclouders
Copy link
Contributor

Results for GUI-tests https://drone.owncloud.com/owncloud/client/10807/5/1
💥 The GUI tests failed.
GUI Logs: (https://cache.owncloud.com/public/owncloud/client/10807/guiReportUpload/index.html)
Server Logs: ((https://cache.owncloud.com/public/owncloud/client/10807/guiReportUpload/serverlog.log)

@fmoc
Copy link
Contributor Author

fmoc commented Feb 22, 2022

I don't see how the change could make the tests fail, which do not use any of the commandline parsing code. Any ideas?

@TheOneRing
Copy link
Member

If an account is configured to use vfs and and we fail to load that plugin we crash.
I assume the change influences the plugin loading in the unit test.

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing
Copy link
Member

Looks like it was a hickup

@TheOneRing TheOneRing merged commit 14146c8 into 2.10 Feb 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the work/fix-version-info branch February 28, 2022 13:51
@TheOneRing TheOneRing mentioned this pull request Mar 10, 2022
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOneRing TheOneRing TheOneRing requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

owncloud --version reports Using virtual files plugin: off
3 participants
@fmoc @ownclouders @TheOneRing