Don't load folder if we encounter a db error #9477
Conversation
TheOneRing
force-pushed
the
work/handle_locked_db
branch
from
2a30e71
to
d777edd
Compare
|
Kudos, SonarCloud Quality Gate passed! |
| _error = QString::fromUtf8(sqlite3_errmsg(_db)); \ | ||
| } \ | ||
| namespace { | ||
| constexpr auto SQLITE_SLEEP_TIME = 500ms; |
There was a problem hiding this comment.
The sleep is probably not needed as it seems that the sqlite calls them self do block for a certain amount of time.
| } | ||
| return false; |
There was a problem hiding this comment.
This was the main issue, if we failed to prepare the statement we just continued.
| close(); | ||
| QFile::remove(filename); | ||
| QFile fileToRemove(filename); | ||
| if (!fileToRemove.remove()) { |
There was a problem hiding this comment.
If removing the broken db failed we are not ready...
There was a problem hiding this comment.
What do you mean? Do we have to implement additional error handling?
There was a problem hiding this comment.
No just return false, the code was meant to fix a corrupted db by removing it.
However if removing the broken db fails.... this pr provides the required error handling.
| close(); | ||
| QFile::remove(filename); | ||
| QFile fileToRemove(filename); | ||
| if (!fileToRemove.remove()) { |
There was a problem hiding this comment.
What do you mean? Do we have to implement additional error handling?
Fixes: #9147