Check basic auth credentials in wizard #9697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
requested changes
May 19, 2022
| @@ -189,6 +187,11 @@ void SetupWizardController::nextStep(std::optional<PageIndex> currentPage, std:: | |||
| }); | |||
|
|
|||
| connect(messageBox, &QMessageBox::accepted, this, [this, showFirstPage]() { | |||
| // when moving back to this page (or retrying a failed credentials check), we need to make sure existing cookies | |||
There was a problem hiding this comment.
Is this triggered every time we go back or only when we displayed an error?
There was a problem hiding this comment.
Every time the page is instantiated.
added 3 commits
May 20, 2022 13:09
This way, users don't unexpectedly have to re-login after the wizard completes if they entered the wrong credentials.
fmoc
force-pushed
the
work/check-basic-auth-creds-in-wizard
branch
from
5613bea
to
1c765a3
Compare
delete-merged-branch
bot
deleted the
work/check-basic-auth-creds-in-wizard
branch
|
Kudos, SonarCloud Quality Gate passed! |
_is_blacklisted.png){kind=link}
_are_copied_over_to_the_server.png){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, users don't unexpectedly have to re-login after the wizard completes if they entered the wrong credentials.
Fixes #9623.
Please note that there is one issue which I haven't been able to fully resolve. When moving back from the last page to the second one, the wizard re-checks the auth type (which should not be necessary but also shouldn't hurt). For some reason, this time, the lookup fails. You can move forward from the first page just fine, though, and the lookup works again.