Fix bookmark creation in GNOME, XFCE etc.

[fmoc]

Gtk+ 3 based desktops store bookmarks information in another location. The old path was valid for Gtk+ 2 only.

Tested on xUbuntu 20.04, 22.04, Fedora 36, openSUSE Leap 15.3.

[TheOneRing]

Are there still gtk2 distros? (should we handle both locations)

[fmoc]

I don't think there are any left. Gtk+ 2.0 has been deprecated for a while now. Even Xfce adopted Gtk+ 3 around 2015.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[HanaGemela]

Expected result: There is a bookmark in the sidebar of the file browser

[jnweiger]

On my Linux Mint 20.3, the file manager is Nemo 5.2.4 and with two active sync folder connections from shiny new 3.0.0-beta.1 client, it looks like this

There is nothing in the bookmarks, the two sync folder connections ownCloud and damkencloud are under My Computer.

[jnweiger]

Same with a trusted old 2.11.0 client. No bookmarks. Sorry.
Do I need to configure something special to make bookmarks appear?
In my world, I would actually not expect that the system adds bookmarks for me. I would want to add my bookmarks myself...

[TheOneRing]

@fmoc

[fmoc]

This is working fine with the latest 3.1 daily on xubuntu 22.04.1. Same goes for 3.0.

In 2.11, bookmark creation is broken, but that is perfectly normal, since this went into 3.0.

I'll try Cinnamon and GNOME next.

[fmoc]

Works as expected in an Ubuntu 22.04.1 with GNOME.

Using Linux Mint 21 with MATE, the bookmark creation does not work. I tracked the bug down to missing escaping: spaces must be escaped as %20. I suppose that we need to apply full URL encoding to the file:// URLs. We should check whether this works for other desktop environments as well.

Cinnamon is working as expected.

[fmoc]

Adding the escaping makes Xfce display the bookmark like this:

Right now, it looks like this:

I am not sure what causes this behavior. Both ways are kind of broken.

On Mint 21 with Cinnamon, the escaping fixes the rendering. (In fact, without escaping, a warning icon
is displayed.)

Similar result on Ubuntu 22.04.1: vs.

I don't think any of this is critical. I'll create an issue for 3.1.

@HanaGemela @jnweiger please limit testing of this change to the following desktop environments for now:

• GNOME
• Xfce
• LXQt
• Cinnamon

[jnweiger]

Seen with owncloud-client_3.0.0~daily20221125+oc-9173_amd64.deb on Linux Mint 20.3 with Cinnamon:

Bookmarks are now there:

[fmoc]

Please post an excerpt of your ~/.config/gtk-3.0/bookmarks.

[jnweiger]

a) I never intentionally used bookmarks, seems the file has now more entries, than visible in the UI. Strange, but ok for me.
b) seems the proper syntax is two elements separated by whitespace. Filename + Display name
Correct fix is of course to avoid whitespace in the folder name.
As a workaround, you could add " (ownCloud)" at the end, then it would look a bit better. :-)

$ cat ~/.config/gtk-3.0/bookmarks 
file:///home/testy/corona corona
file:///home/testy/ownCloud ownCloud
file:///home/testy/damkenCloud damkenCloud
file:///home/testy/Documents Documents
file:///home/testy/Downloads Downloads
file:///home/testy/ownCloud - admin@demo.owncloud.org
file:///home/testy/testpilotcloud - demo@demo.owncloud.org

In my home, I actually have

$ ls -1d corona ownCloud damkenCloud Documents Downloads ownCloud\ -\ admin@demo.owncloud.org testpilotcloud\ -\ demo@demo.owncloud.org
ls: cannot access 'corona': No such file or directory
damkenCloud
Documents
Downloads
ownCloud
'ownCloud - admin@demo.owncloud.org'
'testpilotcloud - demo@demo.owncloud.org'

[fmoc]

Please replace the spaces with %20, that should help. In fact, that is what #10280 is supposed to do.

[jnweiger]

Added a new account (the one with cloud.fablab ...):

3& [testy:~] $ cat ~/.config/gtk-3.0/bookmarks 
file:///home/testy/corona corona
file:///home/testy/ownCloud ownCloud
file:///home/testy/damkenCloud damkenCloud
file:///home/testy/Documents Documents
file:///home/testy/Downloads Downloads
file:///home/testy/ownCloud jw@cloud.owncloud.com
file:///home/testy/ownCloud%20-%20J%C3%BCrgen%20Weigert@cloud.fablab-nuernberg.de

This time it got proper escaping. OK
The display name is missing, but that is harmless in Cinnamon, it nicely uses the part after the last / as display name.

Bookmarks can be "renamed" in Nemo. After doing so the file looks like this:

3& [testy:~] $ cat ~/.config/gtk-3.0/bookmarks 
file:///home/testy/corona corona
file:///home/testy/ownCloud ownCloud
file:///home/testy/damkenCloud damkenCloud
file:///home/testy/Documents Documents
file:///home/testy/Downloads Downloads
file:///home/testy/ownCloud jw@cloud.owncloud.com
file:///home/testy/ownCloud%20-%20J%C3%BCrgen%20Weigert@cloud.fablab-nuernberg.de cloud.fablab-nuernberg.de

Just right. the whitesapaces that should be escaped remain escaped, the one that shouldn't isn't. OK.

Confirmed fixed from my side.