Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve oauth error handling #9813

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Improve oauth error handling #9813

merged 3 commits into from
Jun 28, 2022

Conversation

TheOneRing
Copy link
Member

@TheOneRing TheOneRing commented Jun 22, 2022 •
edited

Depends on: #9815
With the ownCloud 10 app we used to be redirected to a theme "you can now close the browser window" page.
With oidc we will display our own page which looks kind of unprofessional.
This change starts theming the web page we display.

Old:
image

New:
image

@fmoc thx for the css :D

@TheOneRing TheOneRing added this to the 3.0 milestone Jun 22, 2022
@TheOneRing TheOneRing linked an issue Jun 22, 2022 that may be closed by this pull request
Better handle wrong user error after oauth refresh #9772
Closed
@TheOneRing TheOneRing requested a review from a team June 22, 2022 14:46
@TheOneRing TheOneRing changed the title Work/oath error Improve oauth error handling Jun 22, 2022
@TheOneRing TheOneRing mentioned this pull request Jun 22, 2022
Merged
fmoc
fmoc approved these changes Jun 28, 2022
View reviewed changes
src/common/utility.cpp Outdated Show resolved Hide resolved
@ownclouders
Copy link
Contributor

Results for GUI-tests https://drone.owncloud.com/owncloud/client/12226/6/1

💥 The GUI tests failed.

GUI Logs: https://cache.owncloud.com/public/owncloud/client/12226/guiReportUpload/index.html

Server Logs: https://cache.owncloud.com/public/owncloud/client/12226/guiReportUpload/serverlog.log

Screenshots:

@TheOneRing TheOneRing merged commit 0846df8 into master Jun 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the work/oath_error branch June 28, 2022 13:32
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjv erikjv erikjv approved these changes

@fmoc fmoc fmoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Better handle wrong user error after oauth refresh
4 participants
@TheOneRing @ownclouders @erikjv @fmoc