Remove unneeded string operations #9910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for GUI-tests https://drone.owncloud.com/owncloud/client/12481/6/1 💥 The GUI tests failed. GUI Logs: https://cache.owncloud.com/public/owncloud/client/12481/guiReportUpload/index.html |
TheOneRing
force-pushed
the
work/performance
branch
from
442bc5e
to
45182d8
Compare
TheOneRing
commented
Jul 12, 2022
| @@ -45,8 +45,8 @@ int oc_mkdir(const QString &path) | |||
| static mbchar_t wd_buffer[WD_BUFFER_SIZE]; | |||
|
|
|||
| typedef struct { | |||
| QByteArray result; | |||
There was a problem hiding this comment.
Not sure about the value of that unit test by now.....
TheOneRing
force-pushed
the
work/performance
branch
from
d2f080e
to
2444d98
Compare
TheOneRing
force-pushed
the
work/performance
branch
from
2444d98
to
c5c84a5
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
CI hanged with the following message: starting tests
11:21:42:280 Info: Starting server of Squish version 6.7.3 Alpha.
11:21:42:288 Info: Listening on 0.0.0.0:4322
11:21:42:288 Info: Listening on ws://127.0.0.1:45009?zWKcD9u1ONE8SoLEWr_N
11:21:42:288 Info: Announcing server presence via SSDP Tests are not running. Restarted CI. |
fmoc
suggested changes
Jul 26, 2022
|
|
||
| if (vfs && vfs->statTypeVirtualFile(file_stat.get(), &handle->ffd)) { | ||
| if (vfs && vfs->statTypeVirtualFile(file_stat.get(), &handle->ffd)) { |
There was a problem hiding this comment.
The indentation is more off than it used to be. Please revise and if necessary fix for the entire file once and for all.
fmoc
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.