Don't check for db exists #9918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/if_exists
branch
from
9ac1183
to
41279de
Compare
TheOneRing
force-pushed
the
work/if_exists
branch
from
41279de
to
698a156
Compare
|
Results for GUI-tests https://drone.owncloud.com/owncloud/client/12584/6/1 💥 The GUI tests failed. GUI Logs: https://cache.owncloud.com/public/owncloud/client/12584/guiReportUpload/index.html Server Logs: https://cache.owncloud.com/public/owncloud/client/12584/guiReportUpload/serverlog.log Screenshots: |
In context of #6049 a check for the existance of the db file was introduced. That check is performed before every db access... so several 100 times per second.
TheOneRing
force-pushed
the
work/if_exists
branch
from
698a156
to
8351736
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
fmoc
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In context of #6049 a check for the existance of the db file was introduced.
That check is performed before every db access... so serveral 100 times per second.