Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't abort sync to hydrate files #9956

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Don't abort sync to hydrate files #9956

merged 1 commit into from
Jul 28, 2022

Conversation

TheOneRing
Copy link
Member

@TheOneRing TheOneRing commented Jul 26, 2022 •
edited

Notes for testing:

  • Lots of files online
  • Initial sync
  • While the sync is running, double click on a placeholder already created
    • The file should be downloaded in reasonable time
    • The sync progress bar should behave sensible
    • No warnings are expected
    • The initial sync continues

@TheOneRing TheOneRing requested a review from a team July 26, 2022 12:01
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing TheOneRing changed the base branch from master to 2.11 July 28, 2022 07:34
@TheOneRing TheOneRing added this to the 2.11.0 milestone Jul 28, 2022
dragotin
dragotin approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not look too dangerous because it "just" removes some stuff. The "QA Question" however is if everything is still working of course... so well, approve here, but still it is a dangerous thing ;-)

@TheOneRing TheOneRing merged commit 2535b9b into 2.11 Jul 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the work/don_t_abort branch July 28, 2022 09:56
This was referenced Aug 3, 2022
Closed
Closed
@jnweiger
Copy link
Contributor

The description hydrates a file. I asume the subject line is wrong. Right?

@TheOneRing TheOneRing changed the title Don't abort sync to dehydrate files Don't abort sync to hydrate files Aug 10, 2022
@TheOneRing
Copy link
Member Author

Yes looks like I massed that up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragotin dragotin dragotin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheOneRing @jnweiger @dragotin