Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleep before JS tests #681

Closed
wants to merge 1 commit into from
Closed

Add sleep before JS tests #681

wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 14, 2020

to see if the intermittent JS tests failures are just a startup timing issue

issue #680

@phil-davis phil-davis self-assigned this Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #681 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #681   +/-   ##
=========================================
  Coverage     17.22%   17.22%           
  Complexity        1        1           
=========================================
  Files            57       57           
  Lines          1138     1138           
=========================================
  Hits            196      196           
  Misses          942      942

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91441f0...0f36586. Read the comment docs.

@phil-davis
Copy link
Contributor Author

When I restart the nightly drone job it is always passing. And when I restart this drone job it is also always passing. To really be able to test this I need to be able to ensure that the drone pipeline starts on a new drone agent - because it is likely that the timing issue is only going to be a problem onn a new agent that needs to actually fetch ever docker... image from across the network.

@phil-davis
Copy link
Contributor Author

Nightly results are better since PR #682
No need for a timing hack like this.

@phil-davis phil-davis closed this Jan 24, 2020
@phil-davis phil-davis deleted the js-test-fails branch January 24, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant