Merge pull request #27269 from owncloud/upload_filter_issue7496_backend

#7496 Don`t allow upload of files with extension .part
owncloud · Mar 29, 2017 · 6ee78af · 6ee78af
2 parents ff126a5 + 6799445
commit 6ee78af
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/lib/private/legacy/util.php b/lib/private/legacy/util.php
@@ -1402,6 +1402,12 @@ public static function isValidFileName($file) {
 		if (\OC\Files\Filesystem::isIgnoredDir($trimmed)) {
 			return false;
 		}
+
+		// detect part files
+		if (preg_match('/' . \OCP\Files\FileInfo::BLACKLIST_FILES_REGEX . '/', $trimmed) !== 0) {
+			return false;
+		}
+
 		foreach (str_split($trimmed) as $char) {
 			if (strpos(\OCP\Constants::FILENAME_INVALID_CHARS, $char) !== false) {
 				return false;

diff --git a/tests/lib/UtilTest.php b/tests/lib/UtilTest.php
@@ -10,6 +10,9 @@
 
 use OC_Util;
 
+/**
+ * @group DB
+ */
 class UtilTest extends \Test\TestCase {
 	public function testGetVersion() {
 		$version = \OCP\Util::getVersion();
@@ -234,6 +237,13 @@ public function filenameValidationProvider() {
 			['.. ', false],
 			['. ', false],
 			[' .', false],
+			// part files not allowed
+			['.part', false],
+			['notallowed.part', false],
+			['neither.filepart', false],
+			// part in the middle is ok
+			['super movie part one.mkv', true],
+			['super.movie.part.mkv', true],
 		];
 	}