Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
nortmalize path before adding it to the fscache to avoid multiple fsc…
…ache entries for the same file
- Loading branch information
d7f4394
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is necessary? paths are already normalized by the filesystem layer before being passed to the cache (and other hooks)
d7f4394
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some cases it seems to bypass the normalizing step in the filesystem layer, e.g. if certain actions get triggered through webdav.
One example where this happens:
I still investigate why this fscache update happens at all. But until we know more this fix will help to prevent duplicates in the database.
Beside that I think it is not a bad idea to have the normalizing step as low as possible in the code stack. This reduces the chance that it gets bypassed.