Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for X-Forwarded-For #10624

Closed
LukasReschke opened this issue Aug 25, 2014 · 2 comments · Fixed by #10653
Closed

Add support for X-Forwarded-For #10624

LukasReschke opened this issue Aug 25, 2014 · 2 comments · Fixed by #10653
Labels
enhancement security

Comments

@LukasReschke
Copy link
Member

We need a configuration switch to enable admins to use the X-Forwarded-For header as remote IP address. We should replace all occurrences of $_SERVER['REMOTE_ADDR'] then with it.
@th3fallen
Copy link
Contributor

should this be configurable? Wouldnt it make more sense for the system itself to detect and use whichever is relevant? I.e. If x-forwareded-for header exists log that if not fall back to remote_attr?

@LukasReschke
Copy link
Member Author

that won't work since in a non reverse proxy environment an user might add this header to fake the ip address.

LukasReschke added a commit that referenced this issue Aug 26, 2014
@LukasReschke
Add support for getting the real client IP behind proxies
7acdd01 
Fixes #10624

Fix copy paste fail

Add unittest for comma separated headers

Revert 3rdparty
@LukasReschke LukasReschke mentioned this issue Aug 26, 2014
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for getting the real client IP behind proxies owncloud/core
2 participants
@th3fallen @LukasReschke