Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHVM compliance #10837

Closed
1 task done
DeepDiver1975 opened this issue Sep 3, 2014 · 23 comments
Closed
1 task done

HHVM compliance #10837

DeepDiver1975 opened this issue Sep 3, 2014 · 23 comments

Comments

@DeepDiver1975
Copy link
Member

requires:

@fossxplorer
Copy link

+1 for hhvm support in oC. Will contribute with testing part.

@Spacefish
Copy link

it´s nice to see progress on this. the upgrade of doctrine/dbal was a big part of it. I guess there is one utf8 lib left which does not work with hhvm in the used version. But it can be updated. Lately i managed to get some pages of owncloud running in hhvm by upgrading some libs, but hhvm SEGFAULTED quite often..

@DeepDiver1975 DeepDiver1975 assigned bantu and unassigned DeepDiver1975 Jan 7, 2015
@DeepDiver1975 DeepDiver1975 modified the milestones: 8.1-next, 8.0-current Jan 7, 2015
@DeepDiver1975
Copy link
Member Author

moving to 8.1 - still some paths to walk ....

@bantu bantu changed the title hhvm compliance HHVM compliance Jan 12, 2015
@LukasReschke
Copy link
Member

http://hhvm.h4cc.de/ might also be handy – saw that mentioned in IRC today.

@LukasReschke
Copy link
Member

Current state:
composer-graph

Green = Tested
Yellow = Tested, fails are allowed
Red = Not tested
Grey = Unknown (not using Travis)

@bantu
Copy link

bantu commented Feb 28, 2015

@LukasReschke
Copy link
Member

Yes... HHVM doesn't like the checkServer ini-checks in util.php

I'd say we should disable these checks on HHVM for now?

@DeepDiver1975
Copy link
Member Author

I'd say we should disable these checks on HHVM for now?

agreed! THX

@LukasReschke
Copy link
Member

Will do.

@LukasReschke
Copy link
Member

#14605

@castarco
Copy link

castarco commented Mar 3, 2015

What can be done to improve Owncloud on HHVM by a new programmer that don't know the codebase?

I'm trying to execute OwnCloud on HHVM 3.5 in my server, but I'm having many problems and I want to contribute to fix them.

@RobinMcCorkell
Copy link
Member

@castarco We'd appreciate any bug reports for issues you may have with HHVM, along with full logs and server information (see https://github.com/owncloud/core/blob/master/CONTRIBUTING.md for more details). Not many of us run HHVM setups, and AFAIK we don't test it as part of continuous integration, so HHVM bugs usually go unnoticed. If you could test out the code from master on your setups (on a throwaway database, of course) we'd be very grateful!

@cortopy
Copy link

cortopy commented Mar 23, 2015

What sort of logs would be required? Happy to help although I don't know what's necessary

I've just been trying to set up Owncloud to work with HHVM but I've been unsuccessful. The only page that would show is /owncloud/index.php Any other variation or even a direct link to account gives a 404 file not found message

The "interesting" part is that the log shows that it's not been possible to connect to SQL database. Changing nginx config back to PHP5 sorts the issue but obviously no HHVM

@castarco
Copy link

The 404 error is due to a recent bug appeared in the HHVM 3.6 version. In
the 3.5 version is possible to use it (only for basix features).
El dia 23/03/2015 4:32, "cortopy" notifications@github.com va escriure:

What sort of logs would be required? Happy to help although I don't know
what's necessary

I've just been trying to set up Owncloud to work with HHVM but I've been
unsuccessful. The only page that would show is /owncloud/index.php Any
other variation or even a direct link to account gives a 404 file not found
message

The "interesting" part is that the log shows that it's not been possible
to connect to SQL database. Changing nginx config back to PHP5 sorts the
issue but obviously no HHVM


Reply to this email directly or view it on GitHub
#10837 (comment).

@DeepDiver1975 DeepDiver1975 modified the milestones: 8.1-current, 8.2-next Apr 4, 2015
@PVince81
Copy link
Contributor

@DeepDiver1975 @bantu any update ?

@DeepDiver1975
Copy link
Member Author

9.0 topic - we are not yet there - in addition I question if this is still a higher priority give the fact that php7 will be released soon

@DeepDiver1975 DeepDiver1975 modified the milestones: 9.0-next, 8.2-current Sep 22, 2015
@Spacefish
Copy link

I would still see HHVM support as a benefit compared to PHP7, the mean CPU load generated by HHVM is ~50% lower than with PHP7. They both deliver great response times, but the CPU load is a lot less with HHVM. See: https://kinsta.com/blog/hhvm-vs-php-7/

@DeepDiver1975 DeepDiver1975 modified the milestones: backlog, 9.0-current Nov 6, 2015
@DeepDiver1975
Copy link
Member Author

I'm moving this to the backlog - this really requires some more work power to put into. Anybody is welcome to take care of this. Feel free to get in touch with me anytime.

@COLABORATI
Copy link

hhvm support is absolutely needed for good speed, would be very important to get this done. thanks!

@LukasReschke
Copy link
Member

@COLABORATI Contributions welcome. Otherwise your comment won't change anything. 😉

@owncloud owncloud locked and limited conversation to collaborators Jan 10, 2016
@RobinMcCorkell
Copy link
Member

Migrated from #23596:

HHVM seems to not properly handle casting objects to arrays to access object properties, breaking this code:

foreach((object)(array)$originalPolicy as $name => $value) {

@hodyroff
Copy link
Contributor

With PHP7 we don't need this anymore, or?

@DeepDiver1975
Copy link
Member Author

I'm closing this - HHVM is out of scope for us at the moment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests