-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHVM compliance #10837
Comments
+1 for hhvm support in oC. Will contribute with testing part. |
it´s nice to see progress on this. the upgrade of doctrine/dbal was a big part of it. I guess there is one utf8 lib left which does not work with hhvm in the used version. But it can be updated. Lately i managed to get some pages of owncloud running in hhvm by upgrading some libs, but hhvm SEGFAULTED quite often.. |
moving to 8.1 - still some paths to walk .... |
http://hhvm.h4cc.de/ might also be handy – saw that mentioned in IRC today. |
@DeepDiver1975 server-master-linux-hhvm CI broke. https://ci.owncloud.org/job/server-master-linux-hhvm/database=sqlite,label=master/837/console Any idea/hints? |
Yes... HHVM doesn't like the checkServer ini-checks in util.php I'd say we should disable these checks on HHVM for now? |
agreed! THX |
Will do. |
What can be done to improve Owncloud on HHVM by a new programmer that don't know the codebase? I'm trying to execute OwnCloud on HHVM 3.5 in my server, but I'm having many problems and I want to contribute to fix them. |
@castarco We'd appreciate any bug reports for issues you may have with HHVM, along with full logs and server information (see https://github.com/owncloud/core/blob/master/CONTRIBUTING.md for more details). Not many of us run HHVM setups, and AFAIK we don't test it as part of continuous integration, so HHVM bugs usually go unnoticed. If you could test out the code from master on your setups (on a throwaway database, of course) we'd be very grateful! |
What sort of logs would be required? Happy to help although I don't know what's necessary I've just been trying to set up Owncloud to work with HHVM but I've been unsuccessful. The only page that would show is /owncloud/index.php Any other variation or even a direct link to account gives a 404 file not found message The "interesting" part is that the log shows that it's not been possible to connect to SQL database. Changing nginx config back to PHP5 sorts the issue but obviously no HHVM |
The 404 error is due to a recent bug appeared in the HHVM 3.6 version. In
|
@DeepDiver1975 @bantu any update ? |
9.0 topic - we are not yet there - in addition I question if this is still a higher priority give the fact that php7 will be released soon |
I would still see HHVM support as a benefit compared to PHP7, the mean CPU load generated by HHVM is ~50% lower than with PHP7. They both deliver great response times, but the CPU load is a lot less with HHVM. See: https://kinsta.com/blog/hhvm-vs-php-7/ |
I'm moving this to the backlog - this really requires some more work power to put into. Anybody is welcome to take care of this. Feel free to get in touch with me anytime. |
hhvm support is absolutely needed for good speed, would be very important to get this done. thanks! |
@COLABORATI Contributions welcome. Otherwise your comment won't change anything. 😉 |
Migrated from #23596: HHVM seems to not properly handle casting objects to arrays to access object properties, breaking this code:
|
With PHP7 we don't need this anymore, or? |
I'm closing this - HHVM is out of scope for us at the moment |
requires:
The text was updated successfully, but these errors were encountered: