Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store external storage versions per storage #1096

Closed
plin2 opened this issue Jan 5, 2013 · 9 comments
Closed

Store external storage versions per storage #1096

plin2 opened this issue Jan 5, 2013 · 9 comments

Comments

@plin2
Copy link

plin2 commented Jan 5, 2013

External storage doesn't seem to work the way mount.php suggests:

  • Group mounts don't appear in the group members files list. Directories for each mount have to be manually created in each users files directory.
  • Same applies to external mounts on a user level.
  • Indexing for the files on external storage is done on a user level - not mount level. This will create multiple database entries for the very same files.

The above is resolved in the filesystem branch.

Versioning for the files on external storage is done on a user level - not mount level. This will create multiple copies of the very same files.

Enhancement suggestion:

  • Mounts für external storage should be handled like shared folders.
  • A new directory "External" should be visible in the users (just like the "Shared" folder).
  • Underneath two Directories might show up: "Group" and "User".
  • These directories will show separate directories for each mountpoint for external storage.
  • This will happen automatically once the mount entry is created in mount.php - no manual creation of any directory in any filesystem will be necessary.
  • Indexing of the files on the external storage is done on a mount point basis - which means one external file will have exactly one database entry.
  • File versioning is done once for each mountpoint.
  • File versioning should be done on a "need to copy" basis, which is just before modifikation. Pre-emptive copying files is to be avoided.
@MTGap
Copy link
Contributor

MTGap commented Jan 5, 2013

External storage is now cached per storage in the filesystem branch. However, this still isn't the case for versioning as far as I know.

@plin2
Copy link
Author

plin2 commented Jan 6, 2013

Is 'now' the next release of owncloud? I'm using 4.5.5.

Regarding versioning: you should the able to turn it on/off per mouintpoint

@DeepDiver1975
Copy link
Member

MTGap is talking about the upcoming release OC5

@plin2
Copy link
Author

plin2 commented Jan 11, 2013

Well, right now I'am experiencing very bad performance. Whenever I click on my shared folder the web-interface freezes for hours. Probably a file-scan starts and does a whole lot of database updates (at least I see my mysql-bin.0000xx file growing). And that even though nobody touched any of the shared files ...
Also access performance on the top folders is slow. Does that depend on the number of files in the underlying folders? Maybe 35000 pictures is too much for OC?

Will that behavior improve in OC5?

@plin2
Copy link
Author

plin2 commented Jan 11, 2013

If OC thinks the shared folders need to be scanned again, why cann't it do that in the middle of the night and not get the idea just in that moment when I want to access the files/folders?

@plin2
Copy link
Author

plin2 commented Jan 11, 2013

or do that in the background

@plin2
Copy link
Author

plin2 commented Jan 11, 2013

That is what my mysql-bin file says:

UPDATE `oc_fscache` SET `size`=`size`+'4447' WHERE `id`='40220';
and 
dUPDATE `oc_fscache` SET `size`='4447' , `mtime`='1020014769' , `ctime`='1339158891' , `mimetype`='httpd/unix-directory' , `writable`='1' , `mimepart`='httpd' WHERE `id`='37243';

@TheNinja2k
Copy link

I have also a problem with the local mount of my picture folder. It's no wonder owncloud hangs, when it tries to copy 70 Gigs to the local files_versions folder, because it thinks the files have been changed...
I hope this is fixed in OC5, because it's quite a showstopper if you want to add data to owncloud using local mounts.
Unlike stated here #1055 it's not solved in 4.5.5.

Thanks
TheNinja

@MTGap
Copy link
Contributor

MTGap commented Jan 22, 2013

I guess we didn't backport that one, it wasn't a critical bug. Sorry, but you'll have to wait until ownCloud 5, or you could just make the simple change yourself.

I want to keep this open still because files_versions doesn't store the files per mount. I'll change the title.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants