Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safari] The rename button is located slightly above the normal case #11348

Closed
luciamaestro opened this issue Sep 29, 2014 · 6 comments · Fixed by #13276
Closed

[Safari] The rename button is located slightly above the normal case #11348

luciamaestro opened this issue Sep 29, 2014 · 6 comments · Fixed by #13276

Comments

@luciamaestro
Copy link

Steps to reproduce

  1. Place the mouse over a file or folder

Actual behaviour

The rename button is located slightly above the normal case
screen shot 2014-09-29 at 09 45 21

Server configuration

{"installed":"true","version":"7.0.2.2","versionstring":"7.0.2","edition":""}

Client configuration

browser:Safari

Operating system: Mac 10.9.3

@luciamaestro
Copy link
Author

CC/ @jancborchardt

@jancborchardt
Copy link
Member

Same as #9797 reported by @georgehrke

I don’t have Safari to test cause I don’t have an OS X device. @LukasReschke @georgehrke @owncloud/designers please help.

@georgehrke
Copy link
Contributor

If I remove the top:-21px it's positioned correctly in Safari, but it will break in Chromium
files - owncloud at 04 01 58 pm

@jancborchardt
Copy link
Member

Well, that much I could figure out from looking at the screenshots. ;) We need a solution which works in all cases.

Anyone with Safari and a bit of CSS-Skills around? @raghunayyar?

@Sugaroverdose
Copy link
Contributor

@jancborchardt FYI
Looks crappy, but it positions icon on same place in safari 7, chrome 39 and IE11

#fileList a.action[data-action="Rename"] {
    padding: 16px 14px 17px !important;
    position: relative;
    top: -17px;
    float: right;
}

@jancborchardt
Copy link
Member

@Sugaroverdose can you submit a pull request for that? Then we can test and discuss. :) thanks!

@DeepDiver1975 DeepDiver1975 added this to the 8.0-current milestone Jan 13, 2015
MorrisJobke added a commit that referenced this issue Jan 18, 2015
fix safari rename button positioning #11348
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants