Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system cron will fail with always_populate_raw_post_data check if not configured properly #13994

Closed
LukasReschke opened this issue Feb 9, 2015 · 7 comments · Fixed by #14593
Closed

system cron will fail with always_populate_raw_post_data check if not configured properly #13994

LukasReschke opened this issue Feb 9, 2015 · 7 comments · Fixed by #14593
Assignees
@LukasReschke
Labels
enhancement Type:Bug
Milestone
8.0.3

Comments

@LukasReschke
Copy link
Member 

18:31:01 <Dominian> AnybodyElse: lol
18:31:13 <Dominian> AnybodyElse: Well, here's another thing people might see if they are running cron.php like I am on the system crontab.
18:31:18 <Dominian> PHP is configured to populate raw post data. Since PHP 5.6 this will lead to PHP throwing notices for perfectly valid code.
18:31:21 <Dominian> To fix this issue set <code>always_populate_raw_post_data</code> to <code>-1</code> in your php.ini

We should either add a warning to the admin screen or display the reason somewhere prominently otherwise.

@DeepDiver1975 8.1 or 8.0.1?
@LukasReschke LukasReschke self-assigned this Feb 9, 2015
@karlitschek
Copy link
Contributor

8.0.1 in my opinion

@LukasReschke LukasReschke added this to the 8.0.1-next-maintenance milestone Feb 9, 2015
@ghost
Copy link

ghost commented Feb 9, 2015

@LukasReschke
Isn't there already a warning about this introduced in: #13593

@LukasReschke
Copy link
Member Author

@RealRancor

Yes – but that warning will only be shown for the PHP.ini setting of the webserver. Those are often different than that from the CLI PHP. Also we modify it via .htaccess to an accepted value. Unfortunately that means that in most cases not even that warning will be shown since it automagically works in the web ;-)

But great catch – cool that you keep track of our changes and issues - you rock 🚀 🍻

@ghost
Copy link

ghost commented Feb 9, 2015

@LukasReschke
Ah, missed the part "system cron" in the title of the issue.

@DeepDiver1975 DeepDiver1975 modified the milestones: 8.0.2-next-maintenance, 8.0.1-current-maintenance Feb 27, 2015
@LukasReschke LukasReschke mentioned this issue Feb 27, 2015
Merged
@LukasReschke
Copy link
Member Author

Change is at #14593

@LukasReschke LukasReschke modified the milestones: 8.0.1-current-maintenance, 8.0.2-next-maintenance Feb 27, 2015
LukasReschke added a commit that referenced this issue Feb 27, 2015
@LukasReschke
Add detection for invalid CLI configuration for settings page
b6d8a48 
This change will log all failures that prevent the CLI cronjob from happening to the database and display a warning to administrators when an error happened.

To test:

1. Configure some invalid CLI php.ini settings
2. Enable the CLI cronjob and run php cron.php
3. See the errors printed and also in the admin page
4. Configure the CLI settings correctly
5. Errors should be gone.

Fixes #13994
@DeepDiver1975 DeepDiver1975 modified the milestones: 8.0.2-next-maintenance, 8.0.1-current-maintenance Mar 2, 2015
@MorrisJobke
Copy link
Contributor

@LukasReschke Can I ask you to create the backport PR? Thanks

@MorrisJobke MorrisJobke reopened this Mar 2, 2015
LukasReschke added a commit that referenced this issue Mar 2, 2015
@LukasReschke
Add detection for invalid CLI configuration for settings page
2e85c1f 
This change will log all failures that prevent the CLI cronjob from happening to the database and display a warning to administrators when an error happened.

To test:

1. Configure some invalid CLI php.ini settings
2. Enable the CLI cronjob and run php cron.php
3. See the errors printed and also in the admin page
4. Configure the CLI settings correctly
5. Errors should be gone.

Fixes #13994
@MorrisJobke
Copy link
Contributor

Merged

@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LukasReschke LukasReschke

Labels
enhancement Type:Bug
Projects
None yet
Milestone
8.0.3
Development

Successfully merging a pull request may close this issue.

Add detection for invalid CLI configuration for settings page owncloud/core
4 participants
@MorrisJobke @karlitschek @LukasReschke @DeepDiver1975