Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make settings/js/personal.js unit testable #15352

Closed
rullzer opened this issue Apr 1, 2015 · 1 comment
Closed

Make settings/js/personal.js unit testable #15352

rullzer opened this issue Apr 1, 2015 · 1 comment

Comments

@rullzer
Copy link
Contributor

rullzer commented Apr 1, 2015

Currently the personal settings page is almost impossible to unit test. It would be great to rewrite this so we get more code coverage. And can actually verify if still keeps working ;)

I can imagine this has to be done in various pr's.

PR's blocked by this.

CC: @PVince81

@PVince81
Copy link
Contributor

PVince81 commented Apr 7, 2015

That kind of thing needs to be tagged as "technical debt", not "enhancement" 😄

I agree with you. Eventually we should make all JS code unit-testable with proper wrapping/encapsulation.

@DeepDiver1975 DeepDiver1975 modified the milestones: 9.0-next, 8.2-current Sep 21, 2015
@PVince81 PVince81 modified the milestones: 9.1-next, 9.0-current Feb 12, 2016
@PVince81 PVince81 modified the milestones: 9.1-current, 9.2-next Jun 15, 2016
@PVince81 PVince81 modified the milestones: backlog, 10.0 Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants