[WIP] Only show SSL table header if there are certificates #15345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The inspection completed: 1 new issues |
|
Refer to this link for build results (access rights to CI server needed): |
|
very nice 👍 |
|
So the code there is not really unit testable. We probably need to fix that first before the unit tests can be added here. |
|
Good stuff, thank you! 👍 |
jancborchardt
added a commit
that referenced
this pull request
Apr 7, 2015
[WIP] Only show SSL table header if there are certificates
|
@jancborchardt NEVER merge a PR that is tagged with Developing OR [WIP] OR the next major release. |
|
Reverted via #15432 |
|
@rullzer Can I ask you to open a new PR? Thanks |
|
@rullzer sorry for the mess – only remembered the PR from last week and was focused on reviewing it. :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jancborchardt As requested in #15263
We currently do now have javascript unit tests for the personal page. I'll make a start with that by adding unit tests for this commit later this week. (cc @PVince81)