Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting configuration warnings on admin page #15832

Closed
jnfrmarks opened this issue Apr 23, 2015 · 14 comments
Closed

Conflicting configuration warnings on admin page #15832

jnfrmarks opened this issue Apr 23, 2015 · 14 comments

Comments

@jnfrmarks
Copy link

Steps to reproduce

  1. Install 8.1
  2. Do not set a cacheing model
  3. Go to admin page

Expected behaviour

The only message about cacheing should be that it's not configured

Actual behaviour

I see messages about the APCu version and that cacheing is not configured. I'm thinking that we shouldn't be checking the version if it's not configured.

p329

Server configuration

Ubuntu 14.04
PHP 5.5.9
ownCloud Enterprise Edition 8.1 alpha 2 (testing)

@ghost
Copy link

ghost commented Apr 23, 2015

Hi,

isn't it so that APCu was disabled because of the old version and then the second message appears because there is no other memory cache configured?

@jnfrmarks
Copy link
Author

I was thinking: why are we checking the APCu version if it's not even configured?

@DeepDiver1975
Copy link
Member

Well - the list of warnings might cause confusion - but technically speaking they are correct.

  1. APCu was detected with a wrong version -> warning is reported and not used
  2. Because no other memcache was detected -> warning because performance will not be optimal

@jnfrmarks
Copy link
Author

I agree that they are technically correct. I am just questioning if we should be displaying 1 if no memcache is configured. If we're ok with this, then we can close this issue.

@DeepDiver1975
Copy link
Member

well removing either of these messages can result in confusion as well.

But this is more a UX/tech writer topic @jancborchardt @carlaschroder THX

@jancborchardt
Copy link
Member

It seems like yeah, if no memory cache is configured, then we don’t need the APCu message.

@DeepDiver1975
Copy link
Member

well and then you turn APCu on -> what shall happen?

APCu is broken and you have still no mem cache

@jnfrmarks
Copy link
Author

Then I should get a message saying that APCu is the wrong version.

My issue is we're checking something that isn't yet configured and providing an error to the user on that. We should only be checking it if it's configured.

For instance, when I configured the memcache to XCache, I do not get the APCu error (as expected). If you're saying that we should check it regardless of if memcache is configured in config.php then I would have expected the same warning when XCache was configured.

@jancborchardt
Copy link
Member

Yup, as @jnfrmarks said. Ideally the APCu warning should also mention that it’s for caching.

@DeepDiver1975
Copy link
Member

Ideally the APCu warning should also mention that it’s for caching.

well - let's add a documentation link to it just like we did with the "no mem cache" warning

@carlaschroder
Copy link

OPCache replaces APC in PHP 5.5, and is included so you don't have to install it separately. http://php.net/manual/en/opcache.installation.php I think this may be more than a documentation issue.

@ghost
Copy link

ghost commented Apr 24, 2015

Not exactly as also written here: owncloud-archive/documentation#1056 (comment)

APC is opcode cache and data store
APCu is only data store
OPcache is only opcode cache

So OPCache only replaces one part of APC and APCu is still needed if OPCache is installed.

But i still think the problem described here is because the old/unsupported APCu version got disabled by ownCloud and then the second message also appears because no other cache is installed. To fix this you need either:

  1. Update APCu to 4.0.6 later -> both messages disappear
  2. Install another cache like XCache -> The "no cache" message disappears but the APCu version stays (as you can also enable two cache modules side-by-side AFAIK, no matter if they are compatible or not).

@carlaschroder
Copy link

See how y'all like this one owncloud-archive/documentation#1099

@jnfrmarks jnfrmarks added this to the 8.1-current milestone May 5, 2015
@jnfrmarks
Copy link
Author

Doc looks ok to me.

Can we close this one? @carlaschroder @jancborchardt @DeepDiver1975

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants