Log all upgrade events during upgrade

[MorrisJobke]

Have a look at all the listened events in

core/core/command/upgrade.php

Lines 121 to 166 in 2654696

	$updater->listen('\OC\Updater', 'maintenanceEnabled', function () use($output) {
	$output->writeln('<info>Turned on maintenance mode</info>');
	});
	$updater->listen('\OC\Updater', 'maintenanceDisabled', function () use($output) {
	$output->writeln('<info>Turned off maintenance mode</info>');
	});
	$updater->listen('\OC\Updater', 'maintenanceActive', function () use($output) {
	$output->writeln('<info>Maintenance mode is kept active</info>');
	});
	$updater->listen('\OC\Updater', 'updateEnd',
	function () use($output, $updateStepEnabled, $self) {
	$mode = $updateStepEnabled ? 'Update' : 'Update simulation';
	$status = $self->upgradeFailed ? 'failed' : 'successful';
	$message = "<info>$mode $status</info>";
	$output->writeln($message);
	});
	$updater->listen('\OC\Updater', 'dbUpgrade', function () use($output) {
	$output->writeln('<info>Updated database</info>');
	});
	$updater->listen('\OC\Updater', 'dbSimulateUpgrade', function () use($output) {
	$output->writeln('<info>Checked database schema update</info>');
	});
	$updater->listen('\OC\Updater', 'incompatibleAppDisabled', function ($app) use($output) {
	$output->writeln('<info>Disabled incompatible app: ' . $app . '</info>');
	});
	$updater->listen('\OC\Updater', 'thirdPartyAppDisabled', function ($app) use ($output) {
	$output->writeln('<info>Disabled 3rd-party app: ' . $app . '</info>');
	});
	$updater->listen('\OC\Updater', 'upgradeAppStoreApp', function ($app) use($output) {
	$output->writeln('<info>Update 3rd-party app: ' . $app . '</info>');
	});
	$updater->listen('\OC\Updater', 'repairWarning', function ($app) use($output) {
	$output->writeln('<error>Repair warning: ' . $app . '</error>');
	});
	$updater->listen('\OC\Updater', 'repairError', function ($app) use($output) {
	$output->writeln('<error>Repair error: ' . $app . '</error>');
	});
	$updater->listen('\OC\Updater', 'appUpgradeCheck', function () use ($output) {
	$output->writeln('<info>Checked database schema update for apps</info>');
	});
	$updater->listen('\OC\Updater', 'appUpgrade', function ($app, $version) use ($output) {
	$output->writeln("<info>Updated <$app> to $version</info>");
	});
	$updater->listen('\OC\Updater', 'failure', function ($message) use($output, $self) {
	$output->writeln("<error>$message</error>");
	$self->upgradeFailed = true;

and add listeners for this to updater class. These listeners then log everything. Then web and CLI based updates are fully logged in case of a failure and it doesn't need to rerun the upgrade with a verbose command line option.

I just came to this, because often the upgrade is run and something bad happens. Then you need to reproduce this and add all the listeners and make the upgrade verbose. Logging this directly would help a lot of people I think

Opinions on this?

@LukasReschke @nickvergessen @DeepDiver1975 @karlitschek @rullzer @jancborchardt @Xenopathic @schiesbn @icewind1991 @PVince81

@RealRancor Maybe you have interesting insights from the forum ;)

[MorrisJobke]

ref #17088

[karlitschek]

yes. completely agreed!!!

[schiessle]

agreed, I think it makes totally sense to log this stuff. Especially for a update which is executed only once I would rather log too much than too little to have as much information as possible if something goes wrong.

[ghost]

Sounds a good idea 👍

Had also some additional requests of users in the forums to make the upgrade steps more verbose as often the questions where asked like "what is the update process currently doing".

[oparoz]

Finally! :)
This should make it much easier to quickly pinpoint where the upgrade goes wrong...

Would it be possible to change the log level to 0 and turn debug mode on in verbose mode (if it's not done already)?

[PVince81]

@MorrisJobke didn't we add something recently that changes log level to debug then back during an upgrade ?

[MorrisJobke]

@MorrisJobke didn't we add something recently that changes log level to debug then back during an upgrade ?

Yes. #19441

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.