Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair info during the upgrade isn't being shown #17313

Closed
jvillafanez opened this issue Jul 2, 2015 · 4 comments
Closed

Repair info during the upgrade isn't being shown #17313

jvillafanez opened this issue Jul 2, 2015 · 4 comments

Comments

@jvillafanez
Copy link
Member

Checked upgrading 7.0.6 to 7.0.7 and with MySQL

Steps to reproduce

  1. Install ownCloud 7.0.6 with a MySQL DB
  2. Modify some table charset and the collation to something different than utf8 (checked with charset = latin1 and collation = latin1_bin)
  3. Upgrade the installation to 7.0.7 using cli

Expected behaviour

Messages changing the collation of the tables to utf8 should be shown

Actual behaviour

Those messages aren't shown.

Server configuration

Operating system: ubuntu 14.04

Web server: apache 2.4.7

Database: MySQL

PHP version: 5.5.9

ownCloud version: OC 7.0.7

Updated from an older ownCloud or fresh install: upgrade from 7.0.6

ref #17020

@jvillafanez jvillafanez added this to the 7.0.8-next-maintenance milestone Jul 2, 2015
@MorrisJobke MorrisJobke self-assigned this Jul 2, 2015
@PVince81
Copy link
Contributor

PVince81 commented Jul 2, 2015

Maybe because on OC 7 we simply did not log detailed info.
That has been introduced later, either in 8.0 or 8.1

@MorrisJobke
Copy link
Contributor

Maybe because on OC 7 we simply did not log detailed info.
That has been introduced later, either in 8.0 or 8.1

The emit is fired and the listen was also introduced. I've seen the steps in a local stable7 here. I simply need to check for this specific emit, that didn't show up. ;)

@jvillafanez
Copy link
Member Author

I think the listen is attached to the updater, but the emit isn't there but in the repair object. Probably the signal isn't being forwarded to the updater. Basically, you're listening for the signal in the wrong object.

@ghost ghost modified the milestones: 7.0.9-next-maintenance, 7.0.8-current-maintenance Jul 17, 2015
@ghost ghost modified the milestones: 7.0.10-next-maintenance, 7.0.9-current-maintenance Aug 18, 2015
MorrisJobke added a commit that referenced this issue Aug 18, 2015
* fixes #17313
* already in stable8+: 22bc37c - #13513
@MorrisJobke
Copy link
Contributor

@cmonteroluque I just submitted the fix ;)

@MorrisJobke MorrisJobke modified the milestones: 7.0.9-current-maintenance, 7.0.10-next-maintenance Aug 19, 2015
@MorrisJobke MorrisJobke removed their assignment Oct 5, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants