Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to easily clear the current selection #19564

Closed
oparoz opened this issue Oct 4, 2015 · 11 comments
Closed

Impossible to easily clear the current selection #19564

oparoz opened this issue Oct 4, 2015 · 11 comments

Comments

@oparoz
Copy link
Contributor

oparoz commented Oct 4, 2015

Steps to reproduce

  1. Select a few files
  2. Click anywhere outside the files list

Normal behaviour

  • The selection is cleared
  • The sidebar shows a summary of the current folder (in the future)

Actual behaviour

Nothing happens. There is not even a clear button


@jancborchardt @PVince81

@oparoz oparoz added this to the 8.2.1-next-maintenance milestone Oct 4, 2015
@PVince81
Copy link
Contributor

PVince81 commented Oct 5, 2015

With selection you mean the checkbox selection, not the sidebar highlight ?

Related: #18210

@oparoz
Copy link
Contributor Author

oparoz commented Oct 5, 2015

With selection you mean the checkbox selection, not the sidebar highlight ?

Correct, the sidebar just adapts to the selection

@MorrisJobke
Copy link
Contributor

@owncloud/designers We maybe want to discuss this behaviour change first ;)

@jancborchardt
Copy link
Member

Hm, clicking outside of the files view accidentally and losing the selection is painful as well though. And the »summary of the current folder (in the future)« is not possible yet unfortunately because of owncloud/activity#380

The clear function is clicking the »select all« checkbox on the top left in the header of the files list. Maybe we can make that more obvious with a clear button, taking hints from GNOME’s Nautilus.

@jancborchardt jancborchardt modified the milestones: 9.0-next, 8.2.1-next-maintenance Oct 12, 2015
@oparoz
Copy link
Contributor Author

oparoz commented Oct 12, 2015

Hm, clicking outside of the files view accidentally and losing the selection is painful as well though

Maybe, but that's the universal way to do things.

The clear function is clicking the »select all« checkbox on the top left in the header of the files list.

Well, the first time you click it, all items are selected and only then can you clear the list. I'd call this a workaround, not a proper way to clear a selection.

@jancborchardt
Copy link
Member

Well, the first time you click it, all items are selected and only then can you clear the list. I'd call this a workaround, not a proper way to clear a selection.

Right, so that behavior needs to change:

  • when no files are selected, clicking the checkbox should select all files
  • when some files (or all files) are selected, clicking the checkbox should deselect all files

@PVince81 @schiesbn @owncloud/designers ok?

@MorrisJobke
Copy link
Contributor

when some files (or all files) are selected, clicking the checkbox should deselect all files

That's confusing o.O Why not have it first select all and then on the second click you have the deselect all ...

@jancborchardt
Copy link
Member

@MorrisJobke cause that’s what we have now, and it’s strange. When you have some files selected, you need a way to just clear the selection more than quickly selecting all.

@MorrisJobke
Copy link
Contributor

@MorrisJobke cause that’s what we have now, and it’s strange. When you have some files selected, you need a way to just clear the selection more than quickly selecting all.

I'm okay with that then. Just tried it and it makes more sense with the updated behaviour.

@oparoz
Copy link
Contributor Author

oparoz commented Oct 13, 2015

I did some research

  • You can only deselect elements on Windows if you click on the empty space on the right, when you don't have a preview or detailed pane. You can also click on empty space when in thumbnail view
  • Github does selection the same way ownCloud does (with an additional visual feedback for partial selection)

I think @jancborchardt's proposal could work. The key being to have good visual feedback, like a crossed checkbox when the action is remove_all.
An alternative could be to have a "clear selection" zone. I instinctively click on the controls bar, but maybe there is a study out there which lists what users are trying to do to clear the selection.

@jancborchardt
Copy link
Member

Let’s first just go with I proposed please. It’s a very simple behavior improvement and doesn’t introduce any new elements.

@ghost ghost modified the milestones: 9.1-next, 9.0-current Feb 22, 2016
@PVince81 PVince81 modified the milestones: 9.1-current, 9.2-next Jun 14, 2016
@PVince81 PVince81 added this to the backlog milestone Jan 27, 2017
@PVince81 PVince81 removed this from the 10.0 milestone Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants