-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share autocomplete produces warning in log #20095
Comments
Ah one of my favorite files... |
@LukasReschke your fault! 😜 a7df23c#diff-e574f71b1f320c19e9ffb5c5322146deR280 are those weird casts really needed here? |
Oh that's an is_array, not in_array,... FIX |
LukasReschke
added a commit
that referenced
this issue
Oct 29, 2015
This is an `is_array` operation and not a `in_array` one. Thus this typecast is not required. Fixes #20095
LukasReschke
added a commit
that referenced
this issue
Feb 13, 2016
This is an `is_array` operation and not a `in_array` one. Thus this typecast is not required. Fixes #20095
1 task
LukasReschke
added a commit
that referenced
this issue
Feb 13, 2016
This is an `is_array` operation and not a `in_array` one. Thus this typecast is not required. Fixes #20095
1 task
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps
Expected result
No warning in log
Actual result
It doesn't break any functionality, but somewhat looks like a potential programming error.
Versions
Observed on master (c309193) and also 8.4.1RC1
@rullzer @schiesbn @blizzz
The text was updated successfully, but these errors were encountered: