Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share autocomplete produces warning in log #20095

Closed
PVince81 opened this issue Oct 27, 2015 · 4 comments · Fixed by #20152
Closed

Share autocomplete produces warning in log #20095

PVince81 opened this issue Oct 27, 2015 · 4 comments · Fixed by #20152

Comments

@PVince81
Copy link
Contributor

Steps

  1. Create two users "user1" and "user2"
  2. Create a folder "test"
  3. Share "test" with "user1"
  4. From here, observe the logs
  5. Type "us" in the share with autocomplete field and wait until the dropdown appears

Expected result

No warning in log

Actual result

{"reqId":"ZZqww86BjSNPgg9Exgvk","remoteAddr":"127.0.0.1","app":"PHP","message":"Array to string conversion at \/srv\/www\/htdocs\/owncloud\/core\/ajax\/share.php#363","level":3,"time":"2015-10-27T18:47:48+00:00","method":"GET","url":"\/owncloud\/index.php\/core\/ajax\/share.php?fetch=getShareWith&search=us&limit=200&itemShares%5B0%5D%5B%5D=user1&itemType=file"}

It doesn't break any functionality, but somewhat looks like a potential programming error.

Versions

Observed on master (c309193) and also 8.4.1RC1

@rullzer @schiesbn @blizzz

@rullzer
Copy link
Contributor

rullzer commented Oct 28, 2015

Ah one of my favorite files...

@rullzer
Copy link
Contributor

rullzer commented Oct 28, 2015

@LukasReschke your fault! 😜 a7df23c#diff-e574f71b1f320c19e9ffb5c5322146deR280

are those weird casts really needed here?

@nickvergessen
Copy link
Contributor

Oh that's an is_array, not in_array,...

FIX
IT

@LukasReschke LukasReschke self-assigned this Oct 28, 2015
LukasReschke added a commit that referenced this issue Oct 29, 2015
This is an `is_array` operation and not a `in_array` one. Thus this typecast is not required.

Fixes #20095
@MorrisJobke MorrisJobke added this to the 9.0-current milestone Oct 29, 2015
LukasReschke added a commit that referenced this issue Feb 13, 2016
This is an `is_array` operation and not a `in_array` one. Thus this typecast is not required.

Fixes #20095
LukasReschke added a commit that referenced this issue Feb 13, 2016
This is an `is_array` operation and not a `in_array` one. Thus this typecast is not required.

Fixes #20095
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants