Share autocomplete produces warning in log #20095

Closed
PVince81 opened this Issue Oct 27, 2015 · 3 comments

Projects

None yet

5 participants

@PVince81
Collaborator

Steps

  1. Create two users "user1" and "user2"
  2. Create a folder "test"
  3. Share "test" with "user1"
  4. From here, observe the logs
  5. Type "us" in the share with autocomplete field and wait until the dropdown appears

Expected result

No warning in log

Actual result

{"reqId":"ZZqww86BjSNPgg9Exgvk","remoteAddr":"127.0.0.1","app":"PHP","message":"Array to string conversion at \/srv\/www\/htdocs\/owncloud\/core\/ajax\/share.php#363","level":3,"time":"2015-10-27T18:47:48+00:00","method":"GET","url":"\/owncloud\/index.php\/core\/ajax\/share.php?fetch=getShareWith&search=us&limit=200&itemShares%5B0%5D%5B%5D=user1&itemType=file"}

It doesn't break any functionality, but somewhat looks like a potential programming error.

Versions

Observed on master (c309193) and also 8.4.1RC1

@rullzer @schiesbn @blizzz

@rullzer
Contributor
rullzer commented Oct 28, 2015

Ah one of my favorite files...

@rullzer
Contributor
rullzer commented Oct 28, 2015

@LukasReschke your fault! 😜 a7df23c#diff-e574f71b1f320c19e9ffb5c5322146deR280

are those weird casts really needed here?

@nickvergessen
Contributor

Oh that's an is_array, not in_array,...

FIX
IT

@LukasReschke LukasReschke self-assigned this Oct 28, 2015
@LukasReschke LukasReschke added a commit that referenced this issue Oct 29, 2015
@LukasReschke LukasReschke Remove invalid type-cast
This is an `is_array` operation and not a `in_array` one. Thus this typecast is not required.

Fixes #20095
41689cf
@LukasReschke LukasReschke added a commit that referenced this issue Oct 29, 2015
@LukasReschke LukasReschke Remove invalid type-cast
This is an `is_array` operation and not a `in_array` one. Thus this typecast is not required.

Fixes #20095
a6f180f
@MorrisJobke MorrisJobke added this to the 9.0-current milestone Oct 29, 2015
@LukasReschke LukasReschke added a commit that referenced this issue Feb 13, 2016
@LukasReschke LukasReschke Remove invalid type-cast
This is an `is_array` operation and not a `in_array` one. Thus this typecast is not required.

Fixes #20095
9f3dad8
@LukasReschke LukasReschke referenced this issue Feb 13, 2016
Merged

[stable8.1] Remove invalid type-cast #22363

1 of 1 task complete
@LukasReschke LukasReschke added a commit that referenced this issue Feb 13, 2016
@LukasReschke LukasReschke Remove invalid type-cast
This is an `is_array` operation and not a `in_array` one. Thus this typecast is not required.

Fixes #20095
81b1ce4
@LukasReschke LukasReschke referenced this issue Feb 13, 2016
Merged

[stable8.2] Remove invalid type-cast #22364

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment