Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Allow editing" capability in share by link not disabled #23325

Closed
jesmrec opened this issue Mar 16, 2016 · 4 comments · Fixed by #23346
Closed

"Allow editing" capability in share by link not disabled #23325

jesmrec opened this issue Mar 16, 2016 · 4 comments · Fixed by #23346
Assignees
@rullzer
Labels
feature:sharing regression sev2-high Type:Bug
Milestone
9.1

Comments

@jesmrec
Copy link

jesmrec commented Mar 16, 2016

Steps to reproduce

  1. "Allow editing" capability is enabled in Share API
  2. Share a folder by link -> The link is correctly created
  3. Enable the option "Allow editing" of the just created share
  4. Copy and paste the Share link in a browser -> New content can be uploaded to the shared folder
  5. Disable "Allow editing" capability in Share API -> Share link does not show the option
  6. Refresh the share link in the browser

Actual behaviour

New content can be uploaded/New subfolders can be created through the link in the browser

Expected behaviour

No content can be uploaded/No subfolders can be created, because the capability was disabled.

Server configuration

{"installed":true,"maintenance":false,"version":"9.0.0.19","versionstring":"9.0.0","edition":"Enterprise"}
@jesmrec jesmrec added this to the 9.0.1-current-maintenance milestone Mar 16, 2016
@PVince81
Copy link
Contributor

@rullzer please have a look

@rullzer rullzer self-assigned this Mar 17, 2016
@rullzer
Copy link
Contributor

rullzer commented Mar 17, 2016

Ok PR incomming

rullzer added a commit that referenced this issue Mar 17, 2016
@rullzer
Set proper public webdav permissions when public upload disabled
533fdb4 
Fixes #23325

It can happen that a user shares a folder with public upload. And some
time later the admin disables public upload on the server.

To make sure this is handled correctly we need to check the config value
and reduce the permissions.

Fix is kept small to be easy backportable.
@rullzer rullzer mentioned this issue Mar 17, 2016
Merged
@rullzer
Copy link
Contributor

rullzer commented Mar 17, 2016

PR in #23346

rullzer added a commit that referenced this issue Mar 17, 2016
@rullzer
Set proper public webdav permissions when public upload disabled
9dfcb55 
Fixes #23325

It can happen that a user shares a folder with public upload. And some
time later the admin disables public upload on the server.

To make sure this is handled correctly we need to check the config value
and reduce the permissions.

Fix is kept small to be easy backportable.
rullzer added a commit that referenced this issue Mar 17, 2016
@rullzer
Set proper public webdav permissions when public upload disabled
499eba5 
Fixes #23325

It can happen that a user shares a folder with public upload. And some
time later the admin disables public upload on the server.

To make sure this is handled correctly we need to check the config value
and reduce the permissions.

Fix is kept small to be easy backportable.
rullzer added a commit that referenced this issue Mar 17, 2016
@rullzer
Set proper public webdav permissions when public upload disabled
52eb26d 
Fixes #23325

It can happen that a user shares a folder with public upload. And some
time later the admin disables public upload on the server.

To make sure this is handled correctly we need to check the config value
and reduce the permissions.

Fix is kept small to be easy backportable.
rullzer added a commit that referenced this issue Mar 17, 2016
@rullzer
Set proper public webdav permissions when public upload disabled
a63ce82 
 Fixes #23325

 It can happen that a user shares a folder with public upload. And some
 time later the admin disables public upload on the server.

 To make sure this is handled correctly we need to check the config
 value
 and reduce the permissions.

 Fix is kept small to be easy backportable.
@MorrisJobke MorrisJobke modified the milestones: 9.1-current, 9.0.1-current-maintenance Mar 17, 2016
@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rullzer rullzer

Labels
feature:sharing regression sev2-high Type:Bug
Projects
None yet
Milestone
9.1
Development

Successfully merging a pull request may close this issue.

Set proper public webdav permissions when public upload disabled owncloud/core
5 participants
@rullzer @MorrisJobke @PVince81 @DeepDiver1975 @jesmrec