Exclude autoload_static.php #23935
Merged
Exclude autoload_static.php #23935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composer 1.1 has since yesterday a new performance improvement that will be automatically used for PHP >= 5.6, however this file is incompatible with older PHP versions and thus we need to exclude it from the checks. Note that this performance improvement is only used on >= 5.6 so ownCloud will still run fine on older PHP versions as well.
|
By analyzing the blame information on this pull request, we identified @DeepDiver1975 and @nickvergessen to be potential reviewers |
|
Nice - THX |
|
Exclude from https://github.com/owncloud/core/tree/master/apps/files_external/3rdparty/composer as well, in case it ever gets an update? |
|
Travis is green - let's merge - I want my PRs succeed 👍 |
|
Just seen on stable9 pr - we need to backport this |
DeepDiver1975
pushed a commit
that referenced
this pull request
Apr 12, 2016
Composer 1.1 has since yesterday a new performance improvement that will be automatically used for PHP >= 5.6, however this file is incompatible with older PHP versions and thus we need to exclude it from the checks. Note that this performance improvement is only used on >= 5.6 so ownCloud will still run fine on older PHP versions as well.
DeepDiver1975
added a commit
that referenced
this pull request
Apr 12, 2016
Exclude autoload_static.php (#23935)
|
@DeepDiver1975 Could we backport this to stable8.2? #24008 fails for the same reason. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer 1.1 has since yesterday a new performance improvement that will be automatically used for PHP >= 5.6, however this file is incompatible with older PHP versions and thus we need to exclude it from the checks.
Note that this performance improvement is only used on >= 5.6 so ownCloud will still run fine on older PHP versions as well.
@DeepDiver1975