Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardDAV: multiple groups are served as one CATEGORY with "," in name #25030

Closed
rfc2822 opened this issue Jun 8, 2016 · 7 comments
Closed

CardDAV: multiple groups are served as one CATEGORY with "," in name #25030

rfc2822 opened this issue Jun 8, 2016 · 7 comments
Assignees
Milestone

Comments

@rfc2822
Copy link

rfc2822 commented Jun 8, 2016

Steps to reproduce

  1. Add a contact with two categories, let's say "CatA" and "CatB"
  2. Fetch the VCard for this contact via CardDAV.

Expected behaviour

Because OwnCloud states to support VCard 4, the appropriate mechanism (KIND/MEMBER) should be used. However, this is another problem. When using VCard3 CATEGORIES (like OwnCloud currently does), the expected output would be:

CATEGORIES:CatA,CatB

Actual behaviour

Instead, the , is escaped:

CATEGORIES:CatA\,CatB

which of course causes clients to assign the contact to a new group "CatA,CatB" instead of the two groups "CatA" and "CatB".

Server configuration

Operating system: Debian GNU/Linux 8.4 (jessie)

Web server: Apache/2.4.10 (Debian)

Database: MySQL 5.5.49-0+deb7u1 (Debian)

PHP version: PHP 5.6.19-0+deb8u1

ownCloud version: 9.0.2

Updated from an older ownCloud or fresh install: fresh install of 9.x, but I don't know if there was an update from 9.0.x (I don't think so)

Where did you install ownCloud from: http://download.owncloud.org/download/repositories/stable/Debian_8.0/

Signing status (ownCloud 9.0 and above):

No errors have been found.

List of activated apps:

Enabled:
  - activity: 2.2.1
  - calendar: 1.2.2
  - comments: 0.2
  - contacts: 1.2.0.0
  - dav: 0.1.6
  - federatedfilesharing: 0.1.0
  - federation: 0.0.4
  - files: 1.4.4
  - files_pdfviewer: 0.8.1
  - files_sharing: 0.9.1
  - files_texteditor: 2.1
  - files_trashbin: 0.8.0
  - files_versions: 1.2.0
  - files_videoplayer: 0.9.8
  - firstrunwizard: 1.1
  - gallery: 14.5.0
  - notifications: 0.2.3
  - provisioning_api: 0.4.1
  - systemtags: 0.2
  - tasks: 0.9.0
  - templateeditor: 0.1
  - updatenotification: 0.1.0
Disabled:
  - encryption
  - external
  - files_external
  - user_external
  - user_ldap

The content of config/config.php:

root@debian-test:/var/www/owncloud# sudo -u www-data php occ config:list system
{
    "system": {
        "updatechecker": false,
        "instanceid": "ockii5e7dtm3",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "debian-test.lan"
        ],
        "datadirectory": "\/var\/www\/owncloud\/data",
        "overwrite.cli.url": "http:\/\/debian-test.lan\/owncloud",
        "dbtype": "mysql",
        "version": "9.0.2.2",
        "dbname": "owncloud",
        "dbhost": "localhost",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "logtimezone": "UTC",
        "installed": true,
        "appstore.experimental.enabled": false,
        "maintenance": false,
        "loglevel": 2
    }
}

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

ownCloud log (data/owncloud.log)

no log entries are created when doing the GET

@nickvergessen
Copy link
Contributor

Did you create the contact or assign the groups with the owncloud contacts app, or with another app, e.g. phone

@rfc2822
Copy link
Author

rfc2822 commented Jun 8, 2016

Doesn't matter, the problem occurs in both cases (just tested).

@DeepDiver1975
Copy link
Member

Doesn't matter, the problem occurs in both cases (just tested).

It should make a difference - the vcard is not touched by the backend code.

@DeepDiver1975 DeepDiver1975 self-assigned this Jun 8, 2016
@DeepDiver1975 DeepDiver1975 added this to the 9.1-current milestone Jun 8, 2016
@nickvergessen
Copy link
Contributor

I can see this in the contacts app, it sends the invalid \, in the vcard to the server.

@DeepDiver1975
Copy link
Member

so this is an error in contacts and has to be reported there - https://github.com/owncloud/contacts

most probably this is related to the used vcard library - we has simiar issue in the past already

@nickvergessen
Copy link
Contributor

Reported in owncloud/contacts#433

@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants