Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable8] Hide revert button when no permission to revert #25330

Merged
merged 1 commit into from
Jul 13, 2016

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Jul 1, 2016

Backport of #25288 to stable8.1

Please review @georgehrke @VicDeo @DeepDiver1975 @owncloud/filesystem

Note that this commit did not change anything in the JS side because in this version the "Versions" dropdown is not available at all.

Also: bonus unit tests that came with the backport !

I tested this and it worked fine.

⚠️ don't merge before 8.0.14 is out!

@PVince81 PVince81 added this to the 8.0.15-next-maintenance milestone Jul 1, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @schiessle, @bartv2 and @icewind1991 to be potential reviewers

@PVince81
Copy link
Contributor Author

Please review @DeepDiver1975 @VicDeo @georgehrke @owncloud/filesystem @butonic

@PVince81 PVince81 modified the milestones: 8.0.14, 8.0.15 Jul 12, 2016
@PVince81
Copy link
Contributor Author

8.0.14 should be fine

@PVince81 PVince81 force-pushed the stable8-fix-versionrevertperms branch from 7aa9831 to d31720b Compare July 13, 2016 08:41
@PVince81
Copy link
Contributor Author

Rebased for hopefully better CI results

@PVince81 PVince81 merged commit ee4a797 into stable8 Jul 13, 2016
@PVince81 PVince81 deleted the stable8-fix-versionrevertperms branch July 13, 2016 12:32
@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants