DAV: Return data-fingerprint always when asked #25482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guruz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @PVince81 and @DeepDiver1975 to be potential reviewers |
|
FYI @ogoffart |
| } | ||
|
|
||
| if ($node instanceof \OCA\DAV\Files\FilesHome) { | ||
| if ($node instanceof \OCA\DAV\Connector\Sabre\Node | ||
| || $node instanceof \OCA\DAV\Files\FilesHome) { |
There was a problem hiding this comment.
I'm surprised that FilesHome isn't a Sabre\Node ?
There was a problem hiding this comment.
FileHome implements ICollection
ICollection extends INode
There was a problem hiding this comment.
The if where I moved it out is \OCA\DAV\Connector\Sabre\Node not INode..
|
Looks good 👍 (don't merge before 9.1.1) |
For owncloud/client#5056 Users can configure arbitrary subfolders for syncing, therefore we should always return it when asked for. The sync client makes sure to not always ask for it to save bandwidth.
PVince81
force-pushed
the
data_finger_print_for_all
branch
from
b209ceb
to
15cfd49
Compare
@ogoffart @DeepDiver1975 second review ? Rebased to kick Jenkins |
|
👍 |
DeepDiver1975
pushed a commit
that referenced
this pull request
Aug 13, 2016
For owncloud/client#5056 Users can configure arbitrary subfolders for syncing, therefore we should always return it when asked for. The sync client makes sure to not always ask for it to save bandwidth.
|
master: #25794 |
PVince81
pushed a commit
that referenced
this pull request
Aug 16, 2016
…730ed2353f457f9aa9 [master] DAV: Return data-fingerprint always when asked (#25482)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For owncloud/client#5056
Users can configure arbitrary subfolders for syncing, therefore we should
always return it when asked for.
The sync client makes sure to not always ask for it to save bandwidth.