New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
25532_issue_password_update_notification #25753
Conversation
Applied a new IF ELSE statement to provide a temporary success message on updating a user password in settings. If status is not 'success' the error message is returned as current.
Removed the hard coded string which passed a success message to the user on updating a user password. Instead, it simply displays the returned status from the result object.
Added some unsynced text from the previous commit
Password Change Notification
Jack Davis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
@JackWillDavis, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ringmaster, @MorrisJobke and @PVince81 to be potential reviewers |
Thanks a lot for your contribution @JackWillDavis Please squash your commits into one - THX |
Right, I can't seem to be able to rebase the commits for some reason. Is it better if I just create a new pull request and delete this one? |
if rebase doesn't work - yes please. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Applying a fix for issue #25532
This adds a temporary notification on updating a user password so the user knows it has gone through successfully. Previously, there was no feedback provided to the user unless it failed.