Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25532_issue_password_update_notification #25753

Closed
wants to merge 4 commits into from
Closed

25532_issue_password_update_notification #25753

wants to merge 4 commits into from

Conversation

JackWillDavis
Copy link
Contributor

Applying a fix for issue #25532

This adds a temporary notification on updating a user password so the user knows it has gone through successfully. Previously, there was no feedback provided to the user unless it failed.

Jack Davis and others added 4 commits August 9, 2016 10:11
Applied a new IF ELSE statement to provide a temporary success message
on updating a user password in settings. If status is not 'success' the
error message is returned as current.
Removed the hard coded string which passed a success message to the user
on updating a user password. Instead, it simply displays the returned
status from the result object.
Added some unsynced text from the previous commit
@CLAassistant
Copy link

CLAassistant commented Aug 10, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ JackWillDavis
❌ Jack Davis


Jack Davis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@mention-bot
Copy link

@JackWillDavis, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ringmaster, @MorrisJobke and @PVince81 to be potential reviewers

@DeepDiver1975
Copy link
Member

Thanks a lot for your contribution @JackWillDavis

Please squash your commits into one - THX

@DeepDiver1975
Copy link
Member

@JackWillDavis
Copy link
Contributor Author

Right, I can't seem to be able to rebase the commits for some reason. Is it better if I just create a new pull request and delete this one?

@DeepDiver1975
Copy link
Member

Is it better if I just create a new pull request and delete this one?

if rebase doesn't work - yes please.

@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants