Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass web requests to occ controller if upgrade is needed #26047

Merged
merged 1 commit into from Sep 7, 2016

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Sep 6, 2016

Description

Related Issue

Fixes owncloud/updater#371

Motivation and Context

503 response to requests initiated by updater

How Has This Been Tested?

Manually.

  1. Install 9.1.0
  2. Install local update server
  3. Patch local update server to serve 9.1.1RC1
  4. Patch lib/base.php in 9.1.1RC1
  5. Update 'updater.server.url' => '', in config.php to match local update server
  6. Trigger update from web UI
    ...
  7. Profit!

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VicDeo VicDeo added this to the 9.1.1 milestone Sep 6, 2016
@mention-bot
Copy link

@VicDeo, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @bartv2 and @LukasReschke to be potential reviewers

@VicDeo
Copy link
Member Author

VicDeo commented Sep 6, 2016

@PVince81 please have a look

@VicDeo
Copy link
Member Author

VicDeo commented Sep 6, 2016

Setting severity according to the issue

@VicDeo VicDeo modified the milestones: 9.2, 9.1.1 Sep 6, 2016
@VicDeo
Copy link
Member Author

VicDeo commented Sep 6, 2016

Stable9.1: #26048
Stable9: #26049

@PVince81
Copy link
Contributor

PVince81 commented Sep 7, 2016

Tested, works 👍

@PVince81 PVince81 merged commit a47b5bf into master Sep 7, 2016
@PVince81 PVince81 deleted the cath-needs-upgrade-non-cli branch September 7, 2016 06:31
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 9.1.0 to 9.1.1RC1 fails
3 participants