Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable9] Pass web requests to occ controller if upgrade is needed #26049

Merged
merged 1 commit into from Sep 7, 2016

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Sep 6, 2016

Backport of #26047
See #26047 (comment) for details

@PVince81
Copy link
Contributor

PVince81 commented Sep 7, 2016

Hmm, I don't remember seeing this issue when upgrading to 9.0.5RC1, but don't remember whether I really tested that scenario. Will double check.

@PVince81
Copy link
Contributor

PVince81 commented Sep 7, 2016

@VicDeo I redid a local test without this patch, updating from 9.0.4 to 9.0.5RC1 and it worked without issues, so not sure if this fix is needed. But I can imagine that at some point, someone will have an environment where it happens.

So 👍 from me. @VicDeo please merge if you agree.

@VicDeo
Copy link
Member Author

VicDeo commented Sep 7, 2016

@PVince81 I will check later today.
May be no apps with type filesystem need upgrade for 9.0.5?
In the original issue exception comes from dav app while loading it in base.php

@VicDeo
Copy link
Member Author

VicDeo commented Sep 7, 2016

@PVince81 tested by increasing dav version in 9.0.5RC1 to 0.1.7 that leads to 💥 9.0.4->9.0.5RC1

@VicDeo
Copy link
Member Author

VicDeo commented Sep 7, 2016

and there is no 💥 with this patch -> merging

@PVince81
Copy link
Contributor

PVince81 commented Sep 7, 2016

@VicDeo thanks for checking ! Test failures unrelated -> merge

@PVince81 PVince81 merged commit 9841ede into stable9 Sep 7, 2016
@PVince81 PVince81 deleted the stable9-cath-needs-upgrade-non-cli branch September 7, 2016 17:49
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants