Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache scanner checks for file id multiple times #28670

Closed
tomneedham opened this issue Aug 14, 2017 · 2 comments
Closed

Cache scanner checks for file id multiple times #28670

tomneedham opened this issue Aug 14, 2017 · 2 comments

Comments

@tomneedham
Copy link
Member

In the cache scanner we have a method to update the cache:

$this->cache->put($path, $data);

This attempts to work out if we need to update or insert to the filecache. But the cache->put() method also does this.

https://github.com/owncloud/core/blob/master/lib/private/Files/Cache/Cache.php#L218

Thoughts?

Could we change the call to $cache->put() to $cache->insert() here?

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@felixboehm felixboehm removed this from the triage milestone Apr 10, 2018
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants