Overwriting populated folders using web ui leads to errors and unexpected behaviour. #28844

SergioBertolinSG · 2017-08-29T16:02:25Z

Steps to reproduce

Upload a folder with 5 subfolders with some files inside each folder using web ui.
Upload again the same folder. When conflicts are detected say no.
Upload again the same folder.
Refresh the page.
Duplicate a file in one of the subfolders to upload.
Upload again the same folder.

Expected behaviour

The upload detects that it is an overwrite and asks if the folder should upload again the files.
Showing the conflicts.

Actual behaviour

The behaviour is erratic, sometimes the upload is just ignored, other it warns you with an upload cancelled warning. And others it simply fails this way:

Server configuration

Operating system:
Ubuntu 16.04

Web server:
Apache

Database:
MySQL

PHP version:
7.0

Cache
DB

ownCloud version: (see ownCloud admin page)
(master)
{"installed":"true","maintenance":"false","needsDbUpgrade":"false","version":"10.0.3.0","versionstring":"10.0.3 beta","edition":"Community","productname":"ownCloud"}

Patch 28692 was applied while testing this, no changes.

Updated from an older ownCloud or fresh install:
Fresh

The content of config/config.php:

Are you using external storage, if yes which one: local/smb/sftp/...
No.

Are you using encryption:
No.

Logs

{"reqId":"x1tj5Uy8ZLORpNhi9ncN","level":4,"time":"2017-08-29T16:00:07+00:00","remoteAddr":"HIDDEN_IP","user":"admin","app":"webdav","method":"MKCOL","url":"\/remote.php\/dav\/files\/admin\/VARIAS_CARPETAS","message":"Exception: {\"Message\":\"HTTP\\\/1.1 405 The resource you tried to create already exists\",\"Exception\":\"Sabre\\\\DAV\\\\Exception\\\\MethodNotAllowed\",\"Code\":0,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(590): Sabre\\\\DAV\\\\Server->createCollection('files\\\/admin\\\/VAR...', Object(Sabre\\\\DAV\\\\MkCol))\\n#1 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpMkcol(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#2 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#3 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:MKCOL', Array)\\n#4 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#5 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Server.php(234): Sabre\\\\DAV\\\\Server->exec()\\n#6 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v2\\\/remote.php(31): OCA\\\\DAV\\\\Server->exec()\\n#7 \\\/opt\\\/owncloud\\\/remote.php(175): require_once('\\\/opt\\\/owncloud\\\/a...')\\n#8 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php\",\"Line\":1180,\"User\":\"admin\"}"}
{"reqId":"4P7jap1fLtnJHWo3MgXc","level":4,"time":"2017-08-29T16:00:07+00:00","remoteAddr":"HIDDEN_IP","user":"admin","app":"webdav","method":"MKCOL","url":"\/remote.php\/dav\/files\/admin\/VARIAS_CARPETAS\/carpeta2","message":"Exception: {\"Message\":\"HTTP\\\/1.1 405 The resource you tried to create already exists\",\"Exception\":\"Sabre\\\\DAV\\\\Exception\\\\MethodNotAllowed\",\"Code\":0,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(590): Sabre\\\\DAV\\\\Server->createCollection('files\\\/admin\\\/VAR...', Object(Sabre\\\\DAV\\\\MkCol))\\n#1 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpMkcol(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#2 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#3 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:MKCOL', Array)\\n#4 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#5 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Server.php(234): Sabre\\\\DAV\\\\Server->exec()\\n#6 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v2\\\/remote.php(31): OCA\\\\DAV\\\\Server->exec()\\n#7 \\\/opt\\\/owncloud\\\/remote.php(175): require_once('\\\/opt\\\/owncloud\\\/a...')\\n#8 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php\",\"Line\":1180,\"User\":\"admin\"}"}
{"reqId":"4cKZsoYQ4iMM2LPSpMgZ","level":4,"time":"2017-08-29T16:00:07+00:00","remoteAddr":"HIDDEN_IP","user":"admin","app":"webdav","method":"MKCOL","url":"\/remote.php\/dav\/files\/admin\/VARIAS_CARPETAS\/carpeta1","message":"Exception: {\"Message\":\"HTTP\\\/1.1 405 The resource you tried to create already exists\",\"Exception\":\"Sabre\\\\DAV\\\\Exception\\\\MethodNotAllowed\",\"Code\":0,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(590): Sabre\\\\DAV\\\\Server->createCollection('files\\\/admin\\\/VAR...', Object(Sabre\\\\DAV\\\\MkCol))\\n#1 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpMkcol(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#2 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#3 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:MKCOL', Array)\\n#4 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#5 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Server.php(234): Sabre\\\\DAV\\\\Server->exec()\\n#6 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v2\\\/remote.php(31): OCA\\\\DAV\\\\Server->exec()\\n#7 \\\/opt\\\/owncloud\\\/remote.php(175): require_once('\\\/opt\\\/owncloud\\\/a...')\\n#8 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php\",\"Line\":1180,\"User\":\"admin\"}"}
{"reqId":"bAIGsHcDGyuwYFkkIPDt","level":4,"time":"2017-08-29T16:00:07+00:00","remoteAddr":"HIDDEN_IP","user":"admin","app":"webdav","method":"MKCOL","url":"\/remote.php\/dav\/files\/admin\/VARIAS_CARPETAS\/carpeta4","message":"Exception: {\"Message\":\"HTTP\\\/1.1 405 The resource you tried to create already exists\",\"Exception\":\"Sabre\\\\DAV\\\\Exception\\\\MethodNotAllowed\",\"Code\":0,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(590): Sabre\\\\DAV\\\\Server->createCollection('files\\\/admin\\\/VAR...', Object(Sabre\\\\DAV\\\\MkCol))\\n#1 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpMkcol(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#2 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#3 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:MKCOL', Array)\\n#4 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#5 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Server.php(234): Sabre\\\\DAV\\\\Server->exec()\\n#6 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v2\\\/remote.php(31): OCA\\\\DAV\\\\Server->exec()\\n#7 \\\/opt\\\/owncloud\\\/remote.php(175): require_once('\\\/opt\\\/owncloud\\\/a...')\\n#8 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php\",\"Line\":1180,\"User\":\"admin\"}"}
{"reqId":"E0iMeHpKvR7wmV84NuHc","level":4,"time":"2017-08-29T16:00:07+00:00","remoteAddr":"HIDDEN_IP","user":"admin","app":"webdav","method":"MKCOL","url":"\/remote.php\/dav\/files\/admin\/VARIAS_CARPETAS\/carpeta3","message":"Exception: {\"Message\":\"HTTP\\\/1.1 405 The resource you tried to create already exists\",\"Exception\":\"Sabre\\\\DAV\\\\Exception\\\\MethodNotAllowed\",\"Code\":0,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(590): Sabre\\\\DAV\\\\Server->createCollection('files\\\/admin\\\/VAR...', Object(Sabre\\\\DAV\\\\MkCol))\\n#1 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpMkcol(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#2 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#3 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:MKCOL', Array)\\n#4 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#5 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Server.php(234): Sabre\\\\DAV\\\\Server->exec()\\n#6 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v2\\\/remote.php(31): OCA\\\\DAV\\\\Server->exec()\\n#7 \\\/opt\\\/owncloud\\\/remote.php(175): require_once('\\\/opt\\\/owncloud\\\/a...')\\n#8 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php\",\"Line\":1180,\"User\":\"admin\"}"}
{"reqId":"GBBnt6UVzyulA1SzA2iL","level":4,"time":"2017-08-29T16:00:07+00:00","remoteAddr":"HIDDEN_IP","user":"admin","app":"webdav","method":"MKCOL","url":"\/remote.php\/dav\/files\/admin\/VARIAS_CARPETAS\/carpeta5","message":"Exception: {\"Message\":\"HTTP\\\/1.1 405 The resource you tried to create already exists\",\"Exception\":\"Sabre\\\\DAV\\\\Exception\\\\MethodNotAllowed\",\"Code\":0,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(590): Sabre\\\\DAV\\\\Server->createCollection('files\\\/admin\\\/VAR...', Object(Sabre\\\\DAV\\\\MkCol))\\n#1 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpMkcol(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#2 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#3 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:MKCOL', Array)\\n#4 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#5 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Server.php(234): Sabre\\\\DAV\\\\Server->exec()\\n#6 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v2\\\/remote.php(31): OCA\\\\DAV\\\\Server->exec()\\n#7 \\\/opt\\\/owncloud\\\/remote.php(175): require_once('\\\/opt\\\/owncloud\\\/a...')\\n#8 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php\",\"Line\":1180,\"User\":\"admin\"}"}

Client configuration

Browser
Chrome, Firefox

The text was updated successfully, but these errors were encountered:

PVince81 · 2017-09-01T13:51:25Z

I think this never worked properly...

PVince81 · 2017-09-04T17:17:16Z

@SergioBertolinSG not reproducible on master 7c7e4f9

It is likely that some other of my related PRs fixed it. Can you verify ?

SergioBertolinSG · 2017-09-05T07:15:05Z

Testing in current master, the step 2 simply doesn't happen. When uploading again the folder, it is not detected as an overwrite.

PVince81 · 2017-09-05T08:02:59Z

In my test it worked. I dragged a folder from dolphin (file manager) into the current folder.

Did you drag onto a subfolder maybe ?

SergioBertolinSG · 2017-09-05T08:16:12Z

I do this (on current master):

PVince81 · 2017-09-05T08:17:19Z

oh, so you too see "infinite years"...

PVince81 · 2017-09-05T09:11:09Z

stable10 for me:

PVince81 · 2017-09-05T09:14:31Z

Works for me, see above. Note that the 412 errors are expected, it's the conflict detection that will trigger the conflict dialog.

SergioBertolinSG · 2017-09-05T10:02:41Z

I get 405s
like this for example:
Request Method:MKCOL
Status Code:405 Method Not Allowed

SergioBertolinSG · 2017-09-05T10:03:25Z

In your gif some 405s appear as well.

PVince81 · 2017-09-05T11:32:23Z

Yes, these are expected too: we try to create the folder and the server tells us that it already exists with 405, so we skip it. This saves a server call, because the alternative would be to do two requests: one PROPFIND and then if 404 comes, do a MKCOL, which might also fail if someone created the folder between the two calls. This is Webdav.

PVince81 · 2017-09-05T11:33:00Z

https://github.com/owncloud/core/blob/master/apps/files/js/file-upload.js#L557

PVince81 · 2017-09-06T16:29:23Z

@SergioBertolinSG can you clear the cache and try again ?

SergioBertolinSG · 2017-09-06T16:41:00Z

Still happening.

PVince81 · 2017-09-06T16:52:47Z

Ok, I was able to reproduce it with @SergioBertolinSG's ~~carpets~~ folders but my folders don't cause the issues

PVince81 · 2017-09-06T16:57:34Z

There is something weird happening: the first upload goes through and the fail() method is properly able to find the upload status 412 to display the conflict dialog.

But the second upload, while it goes through fail(), somehow doesn't find the upload object so it cannot find the upload status. This is why the message appears in the notification.

Now to find out why this is happening... Maybe some cached stuff from the previous upload

PVince81 · 2017-09-06T17:06:07Z

Ok, looks like there are zombie past uploads.

I checked the state inside of fail() and the contents of data is not the same as upload.data.
data contains the correct data with the jqXHR object which has the correct status.
However upload.data.jqXHR contains a weird dead jQuery XHR object without status.

Normally when creating a new upload, the upload object simply receives the new data.
Need to investigate why it's not happening here.

PVince81 · 2017-09-06T17:09:02Z

and the weirdest part, it always only happens with @SergioBertolinSG's folder structure:

VARIAS_CARPETAS
VARIAS_CARPETAS/.DS_Store
VARIAS_CARPETAS/carpeta1
VARIAS_CARPETAS/carpeta1/.DS_Store
VARIAS_CARPETAS/carpeta1/parda copy 2.jpg
VARIAS_CARPETAS/carpeta1/parda copy.jpg
VARIAS_CARPETAS/carpeta1/parda.jpg
VARIAS_CARPETAS/carpeta1/s_033 copy.png
VARIAS_CARPETAS/carpeta1/s_033.png
VARIAS_CARPETAS/carpeta1/the_binding_of_isaac__the_duke_of_flies_by_applesanimatics-d6r52yw.jpg
VARIAS_CARPETAS/carpeta1/vikings-episode-4-trial copy 2.jpg
VARIAS_CARPETAS/carpeta1/vikings-episode-4-trial copy.jpg
VARIAS_CARPETAS/carpeta1/vikings-episode-4-trial.jpg
VARIAS_CARPETAS/carpeta2
VARIAS_CARPETAS/carpeta2/.DS_Store
VARIAS_CARPETAS/carpeta2/parda.jpg
VARIAS_CARPETAS/carpeta2/s_033.png
VARIAS_CARPETAS/carpeta2/the_binding_of_isaac__the_duke_of_flies_by_applesanimatics-d6r52yw.jpg
VARIAS_CARPETAS/carpeta2/vikings-episode-4-trial.jpg
VARIAS_CARPETAS/carpeta3
VARIAS_CARPETAS/carpeta3/.DS_Store
VARIAS_CARPETAS/carpeta3/parda.jpg
VARIAS_CARPETAS/carpeta3/s_033.png
VARIAS_CARPETAS/carpeta3/the_binding_of_isaac__the_duke_of_flies_by_applesanimatics-d6r52yw.jpg
VARIAS_CARPETAS/carpeta3/vikings-episode-4-trial.jpg
VARIAS_CARPETAS/carpeta4
VARIAS_CARPETAS/carpeta4/.DS_Store
VARIAS_CARPETAS/carpeta4/parda.jpg
VARIAS_CARPETAS/carpeta4/s_033.png
VARIAS_CARPETAS/carpeta4/the_binding_of_isaac__the_duke_of_flies_by_applesanimatics-d6r52yw.jpg
VARIAS_CARPETAS/carpeta4/vikings-episode-4-trial.jpg
VARIAS_CARPETAS/carpeta5
VARIAS_CARPETAS/carpeta5/.DS_Store
VARIAS_CARPETAS/carpeta5/parda.jpg
VARIAS_CARPETAS/carpeta5/s_033.png
VARIAS_CARPETAS/carpeta5/the_binding_of_isaac__the_duke_of_flies_by_applesanimatics-d6r52yw.jpg
VARIAS_CARPETAS/carpeta5/vikings-episode-4-trial.jpg

but doesn't happen with mine:

subdir
subdir/sub
subdir/sub/20130317_001.jpg
subdir/sub/1368555495004.jpg
subdir/sub/1391249528060.jpg
subdir/sub/DSC05207.JPG
subdir/IMG_20130910_071929.jpg
subdir/IMG_20131019_144636.jpg
subdir/IMG_20131019_144640.jpg
subdir/IMG_20131022_202138.jpg
subdir/IMG_20131101_135241.jpg
subdir/folders-only
subdir/folders-only/a
subdir/folders-only/b

SergioBertolinSG · 2017-09-07T06:40:23Z

Maybe the hidden files?

SergioBertolinSG · 2017-09-13T10:41:11Z

It happens also in 10.0.2 so not a regression.

PVince81 · 2017-09-13T13:01:21Z

I tried removing the .DS_Store files from all folders and the upload/overwrite works fine now.
So maybe as you said it might be the hidden files messing up something.

PVince81 · 2017-09-13T13:07:39Z

Additional bug (to raise?): the conflict dialog does not show the correct file name on the left, it only shows "carpeta1" for all files that are inside that folder.

PVince81 · 2017-09-13T13:11:36Z

another bug (to raise, performance): seems the subfolders get a PROPFIND several times during the upload instead of only once. Maybe this.uploader._knownDirs is not working or not matching properly with existing folders

PVince81 · 2017-09-13T13:20:11Z

I have the feeling there's a race condition somewhere in the upload code. Sometimes I receive different errors.

The weird thing is that sometimes the "OC.Upload" object arrives uninitialized in the "finish" callback even though it was initialized before and even run the query. The fact that it's uninitialize/unpopulated causes JS errors or deviations from the expected code path.

Since this is random, I'll try adding a lot of log statements to be able to trace the exact code paths and states.

PVince81 · 2017-09-13T13:25:44Z

I can't seem to reproduce the issue after renaming ".DS_Store" to "DS_Store" (no dot). Weird...

And the errors, when they happen, are random. It fails in different locations upon different trials.

PVince81 · 2017-09-13T13:36:50Z

Okay, seems I found something: it seems that jquery.fileupload (in getAJAXSettings()) is making a copy of the original "data", so the later reference is not the same "data" object any more.

felixboehm · 2017-10-17T15:36:58Z

We get this fixed for 10.0.4 ?

PVince81 · 2017-10-17T19:04:33Z

Yes, still on my list

PVince81 · 2017-10-30T15:19:14Z

If I remove the copy logic and have it just a reference, it's even worse: the internal events are triggered in a cyclic manner

PVince81 · 2017-10-30T15:30:20Z

Okay, after digging into the code I found the following: the upload id that is generated doesn't properly include the target upload folder but just the name.

So if you're trying to upload multiple files with the same name but into different folders, it would cause an upload id conflict and mess up when all is done in parallel.

PVince81 · 2017-10-30T15:38:29Z

Seems the upload id is not the problem here as there was an appended timestamp. I'll still provide a fix for this as high concurrency could cause upload id collisions if the timestamp is exactly the same.

There is another problem remaining: at the time of the done event, the uploads array is already empty as if it was cleared.

PVince81 · 2017-10-30T15:56:57Z

This is very random. I have the feeling that sometimes one piece of the upload batch finishes earlier and calls clear(), which disturbs the other not yet sent pieces.

The weird thing is that when I add logging to try and reproduce this, it doesn't happen. clear() is then always called at the end instead of somewhere in the middle...

PVince81 · 2017-10-30T16:08:23Z

Ok, I managed to observe this race condition with logging.

Sometimes it happens that the first items of the transfer finish early and fast, so that there are no more "submitted" items in jquery.fileupload's queue, so it fires "fileuploadstop" which marks the end of the transfer. "fileuploadstop" would simply clear the list of known uploads.

However we still have a list of unprocessed uploads, so I've adjusted the clear() method to keep pending uploads instead of clearing them all.

PR incoming soon.

PVince81 · 2017-10-30T16:09:44Z

Ah, I also wanted to mention that I noticed this behavior when reuploading the same folder within the same page. It almost feels like Chrome is caching the files somewhere so the second upload is much faster, but also more prone to trigger this race condition. This happens even if you upload into a second separate folder.

This likely matches somehow what @SergioBertolinSG observed, except that he reuploaded into the same folder while I uploaded to a second folder.

PVince81 · 2017-10-30T16:15:13Z

@SergioBertolinSG please retest with #29393

lock · 2019-08-01T16:01:05Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

SergioBertolinSG added Type:Bug p2-high Escalation, on top of current planning, release blocker sev2-high labels Aug 29, 2017

SergioBertolinSG added this to the QA milestone Aug 29, 2017

PVince81 self-assigned this Sep 1, 2017

felixboehm modified the milestones: QA, development Sep 4, 2017

PVince81 assigned SergioBertolinSG Sep 4, 2017

PVince81 mentioned this issue Sep 6, 2017

[stable10] Web UI goes back to old DAV endpoint #28924

Merged

davitol added the QA:known label Sep 13, 2017

PVince81 mentioned this issue Sep 13, 2017

10.0.3 Release Notes owncloud-archive/documentation#3360

Closed

PVince81 modified the milestones: development, planned Sep 18, 2017

PVince81 mentioned this issue Oct 30, 2017

Fix folder upload race condition #29393

Merged

9 tasks

DeepDiver1975 closed this as completed in #29393 Nov 3, 2017

ownclouders added the status/STALE label Dec 21, 2017

This was referenced Jan 15, 2018

Duplicate files dialog appears when uploading a folder using drag and drop when having same filenames in the root. #23646

Closed

checkExistingFiles doesn't work well for folders #19594

Closed

lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019

Overwriting populated folders using web ui leads to errors and unexpected behaviour. #28844

Overwriting populated folders using web ui leads to errors and unexpected behaviour. #28844

Comments

SergioBertolinSG commented Aug 29, 2017

Steps to reproduce

Expected behaviour

Actual behaviour

Server configuration

Client configuration

PVince81 commented Sep 1, 2017

PVince81 commented Sep 4, 2017

SergioBertolinSG commented Sep 5, 2017 • edited

PVince81 commented Sep 5, 2017

SergioBertolinSG commented Sep 5, 2017 • edited

PVince81 commented Sep 5, 2017

PVince81 commented Sep 5, 2017

PVince81 commented Sep 5, 2017

SergioBertolinSG commented Sep 5, 2017

SergioBertolinSG commented Sep 5, 2017

PVince81 commented Sep 5, 2017

PVince81 commented Sep 5, 2017

PVince81 commented Sep 6, 2017

SergioBertolinSG commented Sep 6, 2017

PVince81 commented Sep 6, 2017

PVince81 commented Sep 6, 2017

PVince81 commented Sep 6, 2017

PVince81 commented Sep 6, 2017

SergioBertolinSG commented Sep 7, 2017

SergioBertolinSG commented Sep 13, 2017

PVince81 commented Sep 13, 2017

PVince81 commented Sep 13, 2017

PVince81 commented Sep 13, 2017 • edited

PVince81 commented Sep 13, 2017

PVince81 commented Sep 13, 2017

PVince81 commented Sep 13, 2017

felixboehm commented Oct 17, 2017

PVince81 commented Oct 17, 2017

PVince81 commented Oct 30, 2017

PVince81 commented Oct 30, 2017

PVince81 commented Oct 30, 2017

PVince81 commented Oct 30, 2017

PVince81 commented Oct 30, 2017

PVince81 commented Oct 30, 2017

PVince81 commented Oct 30, 2017

lock bot commented Aug 1, 2019

SergioBertolinSG commented Sep 5, 2017 •

edited

SergioBertolinSG commented Sep 5, 2017 •

edited

PVince81 commented Sep 13, 2017 •

edited