Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve public link share mail address input field #29695

Closed
pmaier1 opened this issue Nov 27, 2017 · 8 comments
Closed

Improve public link share mail address input field #29695

pmaier1 opened this issue Nov 27, 2017 · 8 comments
Assignees
Labels
enhancement feature:sharing p1-urgent Critical issue, need to consider hotfix with just that issue
Milestone

Comments

@pmaier1
Copy link
Contributor

pmaier1 commented Nov 27, 2017

The current mail address input field for public link shares is too small and does not work well when entering more than one address. It would be great to have it similar to the following screenshot:

link_addresses

Requirements

  • input field is adaptive (auto-scale)
  • mail addresses become "fixed" by hitting space as in the screenshot
  • mail addresses can be "unfixed"/deleted letter-wise with backspace and have a "x" to delete them at once

A mockup would be great!

@felixheidecke @PVince81

@pmaier1 pmaier1 added enhancement p2-high Escalation, on top of current planning, release blocker labels Nov 27, 2017
@pmaier1 pmaier1 added this to the development milestone Nov 27, 2017
@felixboehm felixboehm added p1-urgent Critical issue, need to consider hotfix with just that issue and removed p2-high Escalation, on top of current planning, release blocker labels Dec 14, 2017
@PVince81 PVince81 modified the milestones: development, planned Jan 12, 2018
@PVince81
Copy link
Contributor

@felixheidecke was this done with #29935 ?

@felixheidecke
Copy link
Contributor

@felixheidecke was this done with #29935 ?

Nope, this was not done so far. @pmaier1 are we sure this is necessary? Can we move this to the backlog? Other things seem more urgent.

@pmaier1
Copy link
Contributor Author

pmaier1 commented Feb 20, 2018

Nope, this was not done so far. @pmaier1 are we sure this is necessary? Can we move this to the backlog? Other things seem more urgent.

Yes, it's important. This is a p1 item in the milestone for the next release. Also it's a prereq for #29938. Let's speak if there are concerns.

@PVince81
Copy link
Contributor

let's use select2 which is already included with ownCloud core, see http://select2.github.io/select2/ and search for "Tagging Support" as agreed when discussing with @felixheidecke

@PVince81
Copy link
Contributor

PVince81 commented Mar 2, 2018

also needs to support autocomplete, see #30645 (comment)

@felixheidecke
Copy link
Contributor

PR is ready to review

@felixheidecke
Copy link
Contributor

Merged

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement feature:sharing p1-urgent Critical issue, need to consider hotfix with just that issue
Projects
None yet
Development

No branches or pull requests

5 participants