Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: share link to contact email does not work any more #30669

Closed
PVince81 opened this issue Mar 2, 2018 · 4 comments
Closed

Regression: share link to contact email does not work any more #30669

PVince81 opened this issue Mar 2, 2018 · 4 comments
Assignees
Labels
p1-urgent Critical issue, need to consider hotfix with just that issue regression server Type:Bug
Milestone

Comments

@PVince81
Copy link
Contributor

PVince81 commented Mar 2, 2018

Steps

  1. Enable the contacts app
  2. In the sharing settings, allow users to send email for link shares
  3. Create a contact "Max Mustermann" with email address "max@example.com"
  4. Create a folder "test"
  5. Create link share for "test"
  6. In the email field, type "max" and wait

Expected result

Dropdown opens with "Max Mustermann" as entry

Actual result

No dropdown / autocomplete, no server request.

Version

stable10
Regression from 10.0.7.

To find the problem, grep for "getShareWithEmail" on 10.0.7 and stable10: on 10.0.7 the code in question still exists in core/js/sharedialogmailview.js but in stable10 it's completely goen.

@felixheidecke did you remove this on purpose when working on the personal note ?

@PVince81 PVince81 added Type:Bug regression p1-urgent Critical issue, need to consider hotfix with just that issue labels Mar 2, 2018
@PVince81 PVince81 added this to the development milestone Mar 2, 2018
@PVince81
Copy link
Contributor Author

PVince81 commented Mar 2, 2018

I also see that we might have some more complications when we switch to the tag-like view from #29695.

Basically we'll need to wire up select2's autocomplete code to the endpoint mentioned in this ticket. So instead of bringing back the old code I suggest to focus on bringing the autcomplete back as part of #30645

@DeepDiver1975
Copy link
Member

killed in here - 1916d25#diff-99ea0d0c9aa0d63172b459efb8c4cb42L133

@felixheidecke
Copy link
Contributor

Japp … I killed it in a misunderstanding. Bringing it back.

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p1-urgent Critical issue, need to consider hotfix with just that issue regression server Type:Bug
Projects
None yet
Development

No branches or pull requests

4 participants