Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose link share email template through APIs #29937

Closed
PVince81 opened this issue Dec 20, 2017 · 11 comments
Closed

Expose link share email template through APIs #29937

PVince81 opened this issue Dec 20, 2017 · 11 comments

Comments

@PVince81
Copy link
Contributor

Provide a way for clients to retrieve the email template through public APIs.

  1. Public API endpoint to retrieve preformatted email template with filename, expiration date as input

  2. Public API endpoint to send out email with body (tech debt from ajax/share.php which needs to be moved anyway, see Sharing 2.0 internals #22209)

This is a follow up of #29935.

I suggest providing a new OCS Share API endpoint for that.

Note that only plain text messages are supported. Not sure if we should support HTML emails as it would require clients and web UI to provide basic formatting.

@michaelstingl @felixheidecke @pmaier1

@PVince81
Copy link
Contributor Author

Also not discussed so far: email subject ?

@PVince81
Copy link
Contributor Author

The email endpoint could potentially be abused to send non-share-related emails to anyone... I don't like this. We could force it to have at least the share id, but still...

@PVince81
Copy link
Contributor Author

PVince81 commented Dec 20, 2017

No, this feature is not really about sending invitation emails.
It's about adding email recipients to an existing link share (see "grouped tickets" concept #29938). So the API endpoint would simply be the same like the one that allows you to add more recipients to the link share, with the option of specifying a personal note. The endpoint will then send an email.

When adding a recipient I'd expect the share id of the original share to be specified.

@michaelstingl
Copy link

Also not discussed so far: email subject ?

For "1. Public API endpoint to retrieve…" subject should be retrieved from oC server too. If I share a link with my mobile mail client, subject will be used. If I share a link with a messaging application, only the body will be used.

@PVince81
Copy link
Contributor Author

@michaelstingl good point. Indeed mobile will use the local mail client, so the subject should be available too.

  • include subject in template response

@SamuAlfageme
Copy link

Could be used to solve owncloud/client#6196

@SamuAlfageme
Copy link

Duplicates Hackweek's #29769 maybe?

@pmaier1
Copy link
Contributor

pmaier1 commented Dec 21, 2017

For #29935 I would also be happy with just "injecting" a note to the notification mail. Not 100% sure if users want to edit the whole template there or if oC should just provide an option to insert a personal note to an existing template (and templates can be edited elsewhere, e.g. templateeditor).

@PVince81 PVince81 modified the milestones: development, planned Jan 12, 2018
@PVince81
Copy link
Contributor Author

moving to planned

@PVince81 PVince81 modified the milestones: development, planned Mar 13, 2018
@PVince81 PVince81 removed their assignment Mar 13, 2018
@pmaier1
Copy link
Contributor

pmaier1 commented Mar 14, 2018

We don't need to make the full template editable but the API should be capable of injecting a personal note as in the WebUI #29696.

@PVince81
Copy link
Contributor Author

moving to triage. personal note is implemented in 10.0.8

@PVince81 PVince81 modified the milestones: development, triage Apr 24, 2018
@PVince81 PVince81 removed this from the triage milestone May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants