Sharing 2.0 internals

[rullzer]

After #19331 we still need to migrate some internal parts. This ticket will keep track of those tasks. After this we should be able to drop more legacy code!

Required

• Migrate apps/files_share/lib to the share manager
  • helper.php => setupfromtoken: Move setupfromtoken to sharemanager #24383
  • maintainer.php => kill: Remove config change hook that deletes link shares #26612
  • mountprovider.php
  • sharedmount.php
  • sharedstorage.php (SharedStorage to new sharing code + cleanup #23919)
  • updater.php
• Migrate hooks from \OC\Share\Hooks (lib/private/share/hooks.php) (Migrate post_userDelete hook to share manager #23773, Migrate post_groupDelete hook to share manager #23841 Remove pre/post_addToGroup hooks for shares #23856 Move post_removeFromGroup to shareManager #23973)
• Move dav app over to new share code ( Move public webdav auth to share manager #23736 )
• Move notify recipient over from ajax/* to sharemanager
• Refactor shared storage ( @icewind1991 ) as in [WIP] Refactor shared storage #12086 (SharedStorage to new sharing code + cleanup #23919)
• Allow federation app to be disabled (so fix the factory)

More:

• Federated sharing accepting etc
• Cleanup exceptions
• Properly translate all errors in the OCS Share API... (Translate OCS Share API error messages #24027)
  • Using https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.4 makes most sense
• Migrate apps/files_sharing/lib/external to the federated file sharing app
• migrate OCS API for federated sharing to the federated file sharing app Cleanup federation phase 1 #32086
• migrate federated share settings from files_sharing to federatedfilesharing (PR: move federated sharing settings to the federatedfilesharing app #24073)

For 9.2:

• Display link reshares properly in webUI Allow multiple link shares #22327 Display all link shares for share owner, even those created by recipients #29519

CC: @PVince81 @schiesbn

[DeepDiver1975]

We might even take advantage of this and analyze the filesystem initialization.
We have to be as lazy as possible ...

[schiessle]

We might even take advantage of this and analyze the filesystem initialization.
We have to be as lazy as possible ...

Good point, we could for example try to only load the share mount points of the current folder. If people have a lot of shares and not all in the root folder this could result in a nice performance improvement... Just thinking.

[MTRichards]

Estimate: 2 weeks.

[rullzer]

@icewind1991 can you help with the shared storage PR? See https://github.com/owncloud/core/tree/cyclyc-share-dep-example

[rullzer]

I've been thinking about moving over the hooks.

Way to go (from my POV) is:

1. Hook is fired
2. Hook somehow calls the sharemanager with a specific function
3. Sharemanager calls a function on each shareProvider

Any objections or other suggestsions? @schiesbn @DeepDiver1975

[rullzer]

This was pushed back to 9.2

[PVince81]

looks like it's more than that. If one passes `includeCollections' it also needs to check all parents to see if they have shares.

• alternative to OCP\Share::getItems where includeCollections is specified: get shares for the given folder, then do the same for every parent. Could be a new utility method in ShareManager

=> not used anywhere else than getItemShared() which is solved in #26615

[PVince81]

• setupfromtoken: Move setupfromtoken to sharemanager #24383
• publicpreview.php: Port publicpreview.php to the share 2.0 API #26611

[PVince81]

• optimize retrieval of share-types properties: Optimize retrieval of share-types property #26641

[VicDeo]

ticked "migrate federated share settings from files_sharing to federatedfilesharing" as PR was merged long time ago