rpm package: Some files have not passed the integrity check. #31703

[svde]

created new issue because you have an automated process to close issues

I'm running owncloud on fedora 28, using the pachaes from the owncloud repo. It complains with:

Some files have not passed the integrity check. Further information on how to resolve this issue can be found in our documentation. (List of invalid files… / Rescan…)

and

Technical information
=====================
The following list covers which files have failed the integrity check. Please read
the previous linked documentation to learn more about the errors and how to fix
them.

Results
=======
- core
	- INVALID_HASH
		- occ

Raw output
==========
Array
(
    [core] => Array
        (
            [INVALID_HASH] => Array
                (
                    [occ] => Array
                        (
                            [expected] => 7e3fce0d7b5c20a7775ed1b548cb2e29bed078d3ca77b01a83d438f671b3d473147d4e8217d2084e17b6fe23a18ba258b11ba60106e23381f1e2889ce14971c4
                            [current] => 1da433da8e3f498422a40b8157ac15c7e188ff03270b47d81a67fc14db52fd8888d54c4cb0f006ad270aaf02ca3fe0028f71e4fafa9266ece37a95d5413693d4
                        )

                )

        )

)

The difference in the file is not significant:

$ diff /var/www/html/owncloud/occ occ -ur
--- /var/www/html/owncloud/occ  2018-04-19 18:15:51.000000000 +0200
+++ occ 2018-06-09 07:50:52.760564427 +0200
@@ -1,4 +1,4 @@
-#!/usr/bin/php
+#!/usr/bin/env php
 <?php
 /**
  * Copyright (c) 2013 Thomas Müller <thomas.mueller@tmit.eu>

The offending file (/var/www/html/owncloud/occ) does verify fine with rpm, which means that it's untouched. I'd like to understand why a file which doesn't pass ownclouds own integrity check is put into the rpm package provided by the owncloud project (https://download.owncloud.org/download/repositories/stable/owncloud/index.html). Would it be possible to exclude this file from the integrity checks in the rpm package?

[ownclouders]

GitMate.io thinks possibly related issues are #24652 (Some files have not passed the integrity check), #31703 (rpm package: Some files have not passed the integrity check.), #30332 (failed the integrity check), #23615 (some files have not passed the integrity check - .htaccess), and #24698 (Some files have not passed the integrity check -- INVALID_HASH).

[svde]

Yes, its the same issue as 31703, which was closed by an automated process.

[PVince81]

ownCloud has an own signature system which checks the integrity of the files.

this is useful to detect whenever people to manual upgrades and forget for example to delete old files, or only partially updated files.

this also means that any patching of the source files will cause integrity check.
in your case, if you do need to patch you can exclude the file from integrity check using https://github.com/owncloud/core/blob/v10.0.9/config/config.sample.php#L1260

a better approach would be sending a PR with the proposed change in the occ command so we can put it in the next release and remove the need for patching

[PVince81]

also: sorry that we missed your other report.

I'll tag this here as bug as we could say it's a bug in the occ command

[svde]

My point is that a rpm package from the owncloud project is shipped with a modified version of the occ command, which trips the signature check.

I think the file which is now on github (and passes the signture checks) will work on FC28. That same file is also in the tar.bz2 file included in the src.rpm. I don't see anything obvious in the owncloud-files.spec file which hints at the file being altered. Perhaps its the rpm build process changing it? If that's the case then we may need to patch the signature list (included in the rpm) so it matches the file signature altered by the rpm build process. Links to the patches:

https://www.eijk.nu/owncloud-files.spec.diff
https://www.eijk.nu/occ.signature.patch

[PVince81]

okay, then this is likely a bug

@crrodriguez can you have a look ?

[PVince81]

@crrodriguez any update ?

[crrodriguez]

fixed in owncloud/administration@2dfa790

[svde]

the 10.0.9 RPM file contains two files failing the integrity check:

Technical information

The following list covers which files have failed the integrity check. Please read
the previous linked documentation to learn more about the errors and how to fix
them.

Results

• core
  • INVALID_HASH
    • occ
• market
  • EXTRA_FILE
    • README.md

Raw output

Array
(
[core] => Array
(
[INVALID_HASH] => Array
(
[occ] => Array
(
[expected] => 7e3fce0d7b5c20a7775ed1b548cb2e29bed078d3ca77b01a83d438f671b3d473147d4e8217d2084e17b6fe23a18ba258b11ba60106e23381f1e2889ce14971c4
[current] => 1da433da8e3f498422a40b8157ac15c7e188ff03270b47d81a67fc14db52fd8888d54c4cb0f006ad270aaf02ca3fe0028f71e4fafa9266ece37a95d5413693d4
)

            )

    )

[market] => Array
    (
        [EXTRA_FILE] => Array
            (
                [README.md] => Array
                    (
                        [expected] => 
                        [current] => b53ebb407cb90a5cf9e28463013f38e6aec3d39b4281187366e02b5fd014be144216a088fc50851635acc50cb71c92ad2407b21e8a4f3433b0f73a32ea066c97
                    )

            )

    )

)

[PVince81]

@crrodriguez can you recheck or is it a mirror issue ?

[svde]

any update?

[svde]

looks like its fixed in owncloud-files-10.0.10-1.1.noarch

[crrodriguez]

@svde yes, should be fixed there already, packages of !current release are not fixed.