Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov percentage fails for acceptance test changes #33498

Open
phil-davis opened this issue Nov 13, 2018 · 3 comments
Open

codecov percentage fails for acceptance test changes #33498

phil-davis opened this issue Nov 13, 2018 · 3 comments

Comments

@phil-davis
Copy link
Contributor

When we make "significant" refactorings or additions to the acceptance tests then we sometimes fail the project codecov by 0.01% - probably this is because we have added to the "total amount of code in the project" but have not increased the coverage visible to PHPunit.

Investigate what PHPunit codecov is including when it calculates "total amount of code in the project" and exclude test-only code from that.

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #31579 (test), #22492 (test), #22485 (test), #32764 (Improve acceptance tests status fail messages), and #32769 (Make targets for acceptance tests).

@phil-davis phil-davis self-assigned this Nov 13, 2018
@PVince81
Copy link
Contributor

without being able to look at the reports we won't be able to easily fix this. deferred

@phil-davis phil-davis removed their assignment Feb 19, 2019
@phil-davis
Copy link
Contributor Author

Cleared myself from assignment since it is no currently practical to investigate. See comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants