Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make targets for acceptance tests #32769

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 20, 2018

Description

Add make targets test-acceptance-api and test-acceptance-webui
Use them in drone

Related Issue

owncloud/QA#582

Motivation and Context

Have a standard way to run acceptance tests using make commands similar to other make test-php-style etc. See QA issue referenced above.

How Has This Been Tested?

Local runs of:

make test-acceptance-api BEHAT_SUITE=apiCapabilities
make test-acceptance-api BEHAT_FEATURE=tests/acceptance/features/apiCapabilities/capabilities.feature

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis added this to the development milestone Sep 20, 2018
@phil-davis phil-davis self-assigned this Sep 20, 2018
@phil-davis phil-davis changed the title Make targets for acceptance tests [PoC] Make targets for acceptance tests Sep 20, 2018
@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

Merging #32769 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32769   +/-   ##
=========================================
  Coverage     64.12%   64.12%           
  Complexity    18684    18684           
=========================================
  Files          1177     1177           
  Lines         70309    70309           
  Branches       1270     1270           
=========================================
  Hits          45089    45089           
  Misses        24850    24850           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.4% <ø> (ø) 18684 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4552629...c85b5a0. Read the comment docs.

@phil-davis phil-davis force-pushed the make-targets-for-acceptance-tests branch 2 times, most recently from 76420a2 to 62039ce Compare September 20, 2018 08:25
@phil-davis phil-davis changed the title [PoC] Make targets for acceptance tests Make targets for acceptance tests Sep 20, 2018
@phil-davis phil-davis force-pushed the make-targets-for-acceptance-tests branch from 62039ce to 38fd438 Compare September 20, 2018 11:51
@phil-davis
Copy link
Contributor Author

Note: if this is the way to go, then I think /tests/drone/test-acceptance.sh script can be removed.

@phil-davis phil-davis force-pushed the make-targets-for-acceptance-tests branch from fe242ac to c85b5a0 Compare September 27, 2018 03:26
@phil-davis
Copy link
Contributor Author

Rebased just now to verify that it all still works.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 2c7b3d4 into master Sep 27, 2018
@PVince81 PVince81 deleted the make-targets-for-acceptance-tests branch September 27, 2018 10:00
@PVince81
Copy link
Contributor

@phil-davis please backport

@phil-davis
Copy link
Contributor Author

Backport stable10 #32892

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants