Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Send OCM requests as JSON #34424

Merged
merged 1 commit into from Feb 8, 2019
Merged

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Feb 8, 2019

Backport of #34321

Description

OCM spec says that POST body should be JSON
https://rawgit.com/GEANT/OCM-API/v1/docs.html

Motivation and Context

How Has This Been Tested?

By creating federated shares between this branch and stable10 and sniffing the traffic with Wireshark

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

@VicDeo VicDeo added this to the development milestone Feb 8, 2019
@VicDeo VicDeo self-assigned this Feb 8, 2019
@VicDeo VicDeo mentioned this pull request Feb 8, 2019
10 tasks
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #34424 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34424   +/-   ##
===========================================
  Coverage        63.5%    63.5%           
  Complexity      19140    19140           
===========================================
  Files            1265     1265           
  Lines           75296    75296           
  Branches         1291     1291           
===========================================
  Hits            47813    47813           
  Misses          27103    27103           
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.59% <ø> (ø) 19140 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/federatedfilesharing/lib/Notifications.php 11.53% <ø> (ø) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e972d...575c90b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #34424 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34424   +/-   ##
===========================================
  Coverage        63.5%    63.5%           
  Complexity      19140    19140           
===========================================
  Files            1265     1265           
  Lines           75296    75296           
  Branches         1291     1291           
===========================================
  Hits            47813    47813           
  Misses          27103    27103           
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.59% <ø> (ø) 19140 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/federatedfilesharing/lib/Notifications.php 11.53% <ø> (ø) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e972d...575c90b. Read the comment docs.

@phil-davis phil-davis merged commit 3a8111a into stable10 Feb 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-ocm-json branch February 8, 2019 15:31
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants