Send OCM requests as JSON

[VicDeo]

Description

OCM spec says that POST body should be JSON
https://rawgit.com/GEANT/OCM-API/v1/docs.html

Motivation and Context

How Has This Been Tested?

By creating federated shares between this branch and stable10 and sniffing the traffic with Wireshark

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[codecov]

Codecov Report

Merging #34321 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #34321   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    18368    18368           
=========================================
  Files          1199     1199           
  Lines         69550    69550           
  Branches       1281     1281           
=========================================
  Hits          45044    45044           
  Misses        24133    24133           
  Partials        373      373

Flag	Coverage Δ	Complexity Δ
#javascript	53.09% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.11% <ø> (ø)	18368 <ø> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
apps/federatedfilesharing/lib/Notifications.php	11.53% <ø> (ø)	3 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1427b...f243273. Read the comment docs.

[codecov]

Codecov Report

Merging #34321 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #34321   +/-   ##
=========================================
  Coverage     64.77%   64.77%           
  Complexity    18370    18370           
=========================================
  Files          1199     1199           
  Lines         69555    69555           
  Branches       1281     1281           
=========================================
  Hits          45056    45056           
  Misses        24126    24126           
  Partials        373      373

Flag	Coverage Δ	Complexity Δ
#javascript	53.09% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.12% <ø> (ø)	18370 <ø> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
apps/federatedfilesharing/lib/Notifications.php	11.53% <ø> (ø)	3 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea04a42...00b3f72. Read the comment docs.

[tomneedham]

Nice - wasn't too tricky. Main thing will be to test that this works with another ownCloud & with an old ownCloud (pre-OMC). Backport, then @diocas can test with CERNBOX

[VicDeo]

@tomneedham I tested this branch against stable10 and it works.

[tomneedham]

ready for review? label says developing still.

[VicDeo]

Unit test has been added

[VicDeo]

@tomneedham ready for review now

[tomneedham]

Code looks good! Don't really have the infra to test this and inspect over the wire. 👍

[PVince81]

@VicDeo please backport

[VicDeo]

stable10: #34424