Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.2.0] Respect 'writable' appdir flag on update #35097

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Apr 25, 2019

Backport of #35072

Description

Check if the current appdir is marked as writable before updating the app

Related Issue

Motivation and Context

Fix App is updated inside the directory that is marked as not writable.

How Has This Been Tested?

see #35031

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@VicDeo VicDeo self-assigned this Apr 25, 2019
@VicDeo VicDeo added this to the development milestone Apr 25, 2019
@VicDeo VicDeo added the p2-high Escalation, on top of current planning, release blocker label Apr 25, 2019
@VicDeo VicDeo changed the base branch from master to release-10.2.0 April 25, 2019 12:58
@VicDeo VicDeo requested a review from PVince81 April 25, 2019 12:59
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #35097 into release-10.2.0 will increase coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.0   #35097      +/-   ##
====================================================
+ Coverage             64.29%    64.3%   +0.01%     
- Complexity            20044    20049       +5     
====================================================
  Files                  1285     1285              
  Lines                 76846    76854       +8     
  Branches               1307     1307              
====================================================
+ Hits                  49410    49423      +13     
+ Misses                27055    27050       -5     
  Partials                381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.5% <91.66%> (+0.01%) 20049 <0> (+5) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/app.php 63.45% <100%> (+1.31%) 179 <0> (+5) ⬆️
lib/private/Installer.php 48.18% <66.66%> (ø) 85 <0> (ø) ⬇️
lib/private/AllConfig.php 95.89% <0%> (+1.36%) 43% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73beb5d...ae83531. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit d310a5d into release-10.2.0 Apr 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the release-10.2.0-fix-35031 branch April 29, 2019 05:52
@PVince81 PVince81 modified the milestones: development, QA May 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - To release p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants