Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.2.0] Set mail_send via old share API #35137

Merged
merged 1 commit into from
May 2, 2019

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented May 2, 2019

Backport of #35136

Description

Partially reverts 129d5e1

Related Issue

Motivation and Context

It's possible to notify group about share multiple times

How Has This Been Tested?

In accordance with #35089

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@VicDeo VicDeo self-assigned this May 2, 2019
@VicDeo VicDeo added this to the development milestone May 2, 2019
@VicDeo VicDeo requested review from PVince81 and sharidas May 2, 2019 07:53
@karakayasemi karakayasemi changed the title Set mail_send via old share API [10.2.0] Set mail_send via old share API May 2, 2019
@VicDeo VicDeo mentioned this pull request May 2, 2019
11 tasks
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #35137 into release-10.2.0 will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.0   #35137      +/-   ##
====================================================
+ Coverage             64.38%   64.39%   +0.01%     
+ Complexity            20049    20047       -2     
====================================================
  Files                  1285     1285              
  Lines                 76851    76840      -11     
  Branches               1308     1308              
====================================================
+ Hits                  49478    49479       +1     
+ Misses                26989    26977      -12     
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.53% <0%> (+0.01%) 20047 <6> (-2) ⬇️
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 87.56% <0%> (+1.7%) 201 <6> (-2) ⬇️
lib/private/Server.php 86.66% <0%> (+0.11%) 253% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9e26c...73b6d92. Read the comment docs.

@PVince81 PVince81 merged commit 8597b07 into release-10.2.0 May 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the release-10.2.0-fixup-35089 branch May 2, 2019 09:16
@PVince81 PVince81 modified the milestones: development, QA May 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants