Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add invalid uids #37765

Closed
C0rby opened this issue Aug 3, 2020 · 2 comments · Fixed by #37766
Closed

Add invalid uids #37765

C0rby opened this issue Aug 3, 2020 · 2 comments · Fixed by #37766
Assignees
@C0rby
Labels
Type:Bug

Comments

@C0rby
Copy link
Contributor

C0rby commented Aug 3, 2020 •
edited

There was a pull request before #37268 which implemented a uid block list.
Add .htaccess, .ocdata, owncloud.db and owncloud.log to that list.
@C0rby C0rby added the Type:Bug label Aug 3, 2020
@C0rby C0rby self-assigned this Aug 3, 2020
@C0rby C0rby mentioned this issue Aug 3, 2020
Merged
11 tasks
@phil-davis
Copy link
Contributor

These normally appear in the default data directory:
.htaccess
.ocdata
owncloud.log

People could, for example, redirect their log somewhere else and then (presumably) username owncloud.log will work.

owncloud.db probably only exists if someone is using SQLite? That is not supported/encouraged for production installs anyway. But probably it will not hurt anyone to ban the username owncloud.db.

IMO it is reasonable to ban these usernames. I wonder if any existing site actually has any of these?

@C0rby
Copy link
Contributor Author

C0rby commented Aug 3, 2020

IMO it is reasonable to ban these usernames. I wonder if any existing site actually has any of these?

I hope not...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@C0rby C0rby

Labels
Type:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add values to the invalid uids list owncloud/core
2 participants
@phil-davis @C0rby