Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Remove space related tests with /shares for favorite #40274

Merged
merged 1 commit into from
Aug 18, 2022
Merged

[tests-only][full-ci] Remove space related tests with /shares for favorite #40274

merged 1 commit into from
Aug 18, 2022

Conversation

amrita-shrestha
Copy link
Contributor

Description

The /Shares related for the spaces WebDAV is removed from core since this is to be implemented and run on ocis.

Related Issue

owncloud/ocis#4154 (comment)

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@amrita-shrestha amrita-shrestha self-assigned this Aug 9, 2022
@amrita-shrestha amrita-shrestha force-pushed the removeSpacesForSharesRelatedTOFAvorite branch 2 times, most recently from eab9aee to b0a577d Compare August 12, 2022 11:25
@amrita-shrestha amrita-shrestha mentioned this pull request Aug 12, 2022
Merged
@amrita-shrestha amrita-shrestha force-pushed the removeSpacesForSharesRelatedTOFAvorite branch from b0a577d to 70bb43d Compare August 15, 2022 07:37
@amrita-shrestha amrita-shrestha mentioned this pull request Aug 15, 2022
Closed
2 tasks
@amrita-shrestha amrita-shrestha marked this pull request as ready for review August 15, 2022 07:56
SagarGi
SagarGi reviewed Aug 15, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM 👍

tests/acceptance/features/apiFavorites/favorites.feature Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the removeSpacesForSharesRelatedTOFAvorite branch from 70bb43d to 5c2289b Compare August 15, 2022 11:25
@amrita-shrestha amrita-shrestha force-pushed the removeSpacesForSharesRelatedTOFAvorite branch from 5c2289b to cf02595 Compare August 18, 2022 05:07
@amrita-shrestha amrita-shrestha force-pushed the removeSpacesForSharesRelatedTOFAvorite branch from cf02595 to b973c38 Compare August 18, 2022 07:16
@amrita-shrestha amrita-shrestha force-pushed the removeSpacesForSharesRelatedTOFAvorite branch from b973c38 to 2b9c4fb Compare August 18, 2022 08:11
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kiranparajuli589
kiranparajuli589 reviewed Aug 18, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

saw-jan
saw-jan reviewed Aug 18, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SagarGi
SagarGi reviewed Aug 18, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@phil-davis phil-davis merged commit 6ead0df into master Aug 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the removeSpacesForSharesRelatedTOFAvorite branch August 18, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan left review comments

@phil-davis phil-davis phil-davis approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amrita-shrestha @phil-davis @kiranparajuli589 @SwikritiT @SagarGi @saw-jan