Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to share current folder (need to display share icon in the breadcrumbs) #4333

Closed
jancborchardt opened this issue Aug 6, 2013 · 38 comments

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Aug 6, 2013

  1. It will be easy to see what is shared
  2. If we add sharing functionality from there, it will be easy to share the folder you’re currently in

Currently there is no way to share a folder from inside it. You have to move outside of it, find it in the list again, and then share it from there.

Solution proposal: Add a »Share« button (only with icon) in the breadcrumb next to the name of the current folder. When that is clicked, open the share modal. That button should also reflect the state of the folder just like the action button, for example showing a world when the folder is shared by public link.

@MTGap what do you think? Also cc @owncloud/designers

@PVince81
Copy link
Contributor

Agreed, would be a nice improvement.

@MorrisJobke MorrisJobke modified the milestone: ownCloud 7 Jun 13, 2014
@MorrisJobke MorrisJobke removed the High label Jun 16, 2014
@jancborchardt jancborchardt modified the milestones: ownCloud 8, ownCloud 7 Jul 2, 2014
@jancborchardt
Copy link
Member Author

Setting for ownCloud 8.

@jancborchardt jancborchardt changed the title As a user, I want to be able to easily share the folder I’m currently in. Display share icon in the breadcrumbs Aug 6, 2014
@DeepDiver1975
Copy link
Member

@jancborchardt close or 8.1? THX

@MorrisJobke
Copy link
Contributor

8.1

@MorrisJobke MorrisJobke modified the milestones: 8.1-next, ownCloud 8 Jan 9, 2015
@jancborchardt
Copy link
Member Author

Yeah, no close since it’s not done and it would be a very good addition to make sharing easier.

@jancborchardt jancborchardt changed the title Display share icon in the breadcrumbs Not possible to share current folder (need to display share icon in the breadcrumbs) Feb 10, 2015
@PeterRay
Copy link

Hi all, I've tryed to fix. I add an icon and also relevant event handler but I stopped because javascript doesn't return the event handler of a button_mouse_click. (I need this to retrive the common function (for sure already developed in controller) that set a folder as shared- I expect to find something like ShareFunction(path,....) ). Sorry but I have no more time to spend to follow javascript lacks. If somebody need code, let me know. thanks. greetings for owncloud design itself

@jancborchardt
Copy link
Member Author

@PeterRay do you have the code on Github? cc @MorrisJobke @PVince81 about the JS issues maybe you can help?

@jancborchardt
Copy link
Member Author

@PeterRay even if the code is not ready, you can open a pull request. Then people can help out. :)

@jancborchardt jancborchardt modified the milestones: 8.2-next, 8.1-current Mar 8, 2015
@nickvergessen
Copy link
Contributor

Are we going to open the sidebar on clicking the share icon?

@jancborchardt
Copy link
Member Author

Are we going to open the sidebar on clicking the share icon?

This is the entire point of this addition. A quick way to share the current folder.

@jancborchardt
Copy link
Member Author

People will never guess this is a button until they inadvertently click on it while trying to access a parent folder

Well, if they do not know then it’s an indicator. As you also suggest. If they do know, it’s a shortcut to the sharing function.

@PVince81
Copy link
Contributor

PVince81 commented Jun 1, 2016

We're past feature freeze, moving this UX enhancement to 9.2

CC @MTRichards @cmonteroluque

@PVince81 PVince81 modified the milestones: 9.2-next, 9.1-current Jun 1, 2016
@ChristophWurst ChristophWurst removed their assignment Jun 2, 2016
@PVince81
Copy link
Contributor

@pmaier1 as we mentioned this when discussing sharing.

Would move to backlog as there is no time to finish the discussion and implement this.

@PVince81 PVince81 modified the milestones: backlog, 10.0 Apr 6, 2017
@pmaier1 pmaier1 added p3-medium Normal priority and removed PM prio 2 labels Dec 21, 2017
@pmaier1 pmaier1 modified the milestones: backlog, planned Dec 21, 2017
@pmaier1
Copy link
Contributor

pmaier1 commented Dec 21, 2017

@felixheidecke
Setting this to 'planned'. Maybe it's an easy low-hanging fruit.

@PVince81 PVince81 modified the milestones: development, planned Feb 26, 2018
@PVince81
Copy link
Contributor

moving to triage for rescheduling

it's not exactly a low hanging fruit as it involves a bit more diggingin the messy code to get at the data of the current folder.

Estimate: 2-4md depending on UI design for the icon (putting icons up there is tricky due to screen sizes, etc)

@PVince81 PVince81 modified the milestones: development, triage Apr 24, 2018
@PVince81 PVince81 modified the milestones: triage, maybe some day May 22, 2018
@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically closed.

@stale stale bot closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests