-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not possible to share current folder (need to display share icon in the breadcrumbs) #4333
Comments
Agreed, would be a nice improvement. |
Setting for ownCloud 8. |
@jancborchardt close or 8.1? THX |
8.1 |
Yeah, no close since it’s not done and it would be a very good addition to make sharing easier. |
Hi all, I've tryed to fix. I add an icon and also relevant event handler but I stopped because javascript doesn't return the event handler of a button_mouse_click. (I need this to retrive the common function (for sure already developed in controller) that set a folder as shared- I expect to find something like ShareFunction(path,....) ). Sorry but I have no more time to spend to follow javascript lacks. If somebody need code, let me know. thanks. greetings for owncloud design itself |
@PeterRay do you have the code on Github? cc @MorrisJobke @PVince81 about the JS issues maybe you can help? |
@PeterRay even if the code is not ready, you can open a pull request. Then people can help out. :) |
Are we going to open the sidebar on clicking the share icon? |
This is the entire point of this addition. A quick way to share the current folder. |
Well, if they do not know then it’s an indicator. As you also suggest. If they do know, it’s a shortcut to the sharing function. |
We're past feature freeze, moving this UX enhancement to 9.2 CC @MTRichards @cmonteroluque |
@pmaier1 as we mentioned this when discussing sharing. Would move to backlog as there is no time to finish the discussion and implement this. |
@felixheidecke |
moving to triage for rescheduling it's not exactly a low hanging fruit as it involves a bit more diggingin the messy code to get at the data of the current folder. Estimate: 2-4md depending on UI design for the icon (putting icons up there is tricky due to screen sizes, etc) |
This issue has been automatically closed. |
Currently there is no way to share a folder from inside it. You have to move outside of it, find it in the list again, and then share it from there.
Solution proposal: Add a »Share« button (only with icon) in the breadcrumb next to the name of the current folder. When that is clicked, open the share modal. That button should also reflect the state of the folder just like the action button, for example showing a world when the folder is shared by public link.
@MTGap what do you think? Also cc @owncloud/designers
The text was updated successfully, but these errors were encountered: