Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Thumbnail creation of Illustrator & Photoshop files. #5510

Closed
drhino opened this issue Oct 24, 2013 · 19 comments
Closed

Feature request: Thumbnail creation of Illustrator & Photoshop files. #5510

drhino opened this issue Oct 24, 2013 · 19 comments

Comments

@drhino
Copy link

drhino commented Oct 24, 2013

Feature request:

Create thumbnails of .ai & .psd file's with imagemagick.
Or with even more options of auto-converting?

It would also be nice to create thumbs of .pdf-files which are larger then ...MB to quickly preview them if you click on it.

@Niduroki
Copy link
Member

@georgehrke

@jancborchardt
Copy link
Member

@georgehrke is this possible to do? If so could you put that in the preview library?

@jancborchardt jancborchardt removed this from the ownCloud 7 milestone Feb 13, 2014
@georgehrke
Copy link
Contributor

I am already working on this, but I was about to publish dedicated apps on apps.owncloud.com

@jancborchardt
Copy link
Member

What do you mean, dedicated apps? Seems like this basic functionality of file previews should just be part of core?

@georgehrke
Copy link
Contributor

What do you mean, dedicated apps?

Write a preview backend and publish it on apps.owncloud.com. we don't need smth like illustrator in core

@DeepDiver1975
Copy link
Member

I am already working on this, but I was about to publish dedicated apps on apps.owncloud.com

Please keep in mind to user public api only - the code checker will block usage of non OCP class names.

@drhino
Copy link
Author

drhino commented Feb 13, 2014

@jancborchardt I don't think its possible to put this in the core? Maybe as an application which you can enable and is already delivered in the core version?
Because you'll need imagemagick on your server and a bit of performance too. So imagemagick can render the image from any (large & small) psd files or ai/pdf/eps/...
It's also possible with php but this takes way to much performance so it's definitely not possible to use this functionality on a shared hosting I guess .. ?

@georgehrke
Copy link
Contributor

@webbakery We already have previews in ownCloud 6. There is already soft dependency on imagick for creating previews of pdf, office and svg files. Illustrator and Photoshop previews are quite easy to implement. I am just not sure if Illustrator is important enough to be shipped with core.

@drhino
Copy link
Author

drhino commented Feb 13, 2014

@georgehrke In my own opinion: I would think it's just great to offer a preview for any extension. Maybe with an option to select the different extensions which you want to convert?
I use ownCloud to backup all the data of created projects. So sometimes I have copies of the same psd-files which are slightly improved. With a preview functionality, I can view all of these files and just download the correct one without having to download e.g. 3 files when I only need one specific. I know I could also save a jpg of each file, but it's hard to keep track. I'm actually more of a Photoshop guy, but someone else could be mor into Illustrator. The same story could be told all over again for someone working with a lot of illustrator files. So I certainly think it would be best to include as much extensions as possible but with the option of selecting which you want to enable in cron to convert them whenever the server has enough time and performance left ... ?

BTW: Any thoughts on converting large psd-files? Like around 1GB? Runs smooth enough? And if psd files are easy to implement, is there also an option for psb-format?

@georgehrke
Copy link
Contributor

in cron to convert them whenever the server has enough time and performance left ... ?

Previews are generated on demand. If you open a directory with files, for which no thumbnail was generated yet, it will be generated. Crons are kind of problematic, because it's not available everywhere, so ownCloud can't depend on it.

is there also an option for psb-format?

It depends on whether or not imagemagick supports psb.

Like around 1GB?

That's definitely something that has to be discussed. I'd personally say to not generate previews for (psd-)files bigger than 1GB.

@jancborchardt
Copy link
Member

PSD and Illustrator, being largely popular image files, are definitely fit for adding to core. Introducing modules which are only available in the app store just for that seems a bit strange. Especially since we already have the soft-dependency on imagemagick.

@drhino
Copy link
Author

drhino commented Feb 13, 2014

@georgehrke Isn't it possible to keep the extension of the files in the database? And if the server is idle, or within a certain of time, it finishes converting the wanted documents (which you can enable in the one application added to owncloud which holds all converting options). It's especially handy for large files, for small files this is just an extra but doesn't really have any value, no?
And thumbnail creation on-the-fly for even small photoshop files is a bit of an overkill, don't you think? If you want to access your files, you should be able to do it right away without having to wait for owncloud to process all kinds of stuff, even if it does this in the background? So to be clear: if I would navigate to a lot of directory's, all the processes are scheduled to create the thumbnails just because I opened that directory? And if I'm not doing anything on the software, the server just stands still without doing nothing?

@jancborchardt Let me figure out what all of the functionality's are of imagemagick. Can't we enable them all? Everyone has specific needs. I don't need them all and I certainly think nobody does, but some people need to convert pdf to jpg, others pdf and ai to jpg, ....
And then we can add a module to owncloud-core which is disabled by default but has the opportunity to convert all kinds of stuff? I think the power of this is really underestimated, e.g: you could just navigate to all your images finding the one you need which can hold a source file that you can use a lot, and then you could find it back much easier without having to navigate to all the directory's if you misplaced this certain file and forgot the name of the file. Stupid example but I think my story makes sense? ... Anybody that see's value in this?

@georgehrke
Copy link
Contributor

And if the server is idle

ownCloud is written in PHP. This means that it runs when you call it (open it in the browser, access it via webdav). There is no daemon running 24/7. This problem is partly solvable by cron jobs, but we don't want a hard dependency on cron jobs.

And thumbnail creation on-the-fly for even small photoshop files is a bit of an overkill, don't you think? If you want to access your files, you should be able to do it right away without having to wait for owncloud to process all kinds of stuff.

There is lazy loading. Previews are being generated once the page was loaded.

@drhino
Copy link
Author

drhino commented Feb 14, 2014

@georgehrke It's not necessary to depend on cron-jobs, but it certainly would be a nice feature for the people who want to use it like this?

That sounds more convenient if you say it like that, stupid of me to actually think otherwise ...

@oparoz
Copy link
Contributor

oparoz commented Sep 2, 2014

From my experience with
#10826

It's not too difficult to add support for new formats, but PSD and AI files have layers and getting consistent results may require quite a bit of tuning.

Also, regarding memory, I don't know if you'll run into the same limitations, but Imagick/PHP wanted close to 1GB of memory to convert a 90MB TIFF file...

@mxz-redhot
Copy link

Hi,

I don't understand everything, but I need to have a thumbnail for Adobe files, specifically for .ai files.

It is possible?
Do you work on this?

Thanks, Owncloud user.

@oparoz
Copy link
Contributor

oparoz commented Sep 19, 2014

I'm not working on this, no, but anybody who can read PHP can duplicate my effort. It should be a 30-60 minutes effort.
The one current caveat is that those files won't show in the gallery and that the app has been modified a lot for the next release, so any effort made to make it work would be short lived.

@oparoz
Copy link
Contributor

oparoz commented Oct 3, 2014

According to BountySource, nobody is that interested, but I've submitted a PR which should make it much, much easier in the future to add new formats supported by Imagemagick.

The gallery app needs some internal changes in order to support the new formats, but it works rather well.

@oparoz
Copy link
Contributor

oparoz commented Oct 4, 2014

Merged. Thumbnails will be generated for .ai, .eps, .ps and .psd.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants