-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Thumbnail creation of Illustrator & Photoshop files. #5510
Comments
@georgehrke is this possible to do? If so could you put that in the preview library? |
I am already working on this, but I was about to publish dedicated apps on apps.owncloud.com |
What do you mean, dedicated apps? Seems like this basic functionality of file previews should just be part of core? |
Write a preview backend and publish it on apps.owncloud.com. we don't need smth like illustrator in core |
Please keep in mind to user public api only - the code checker will block usage of non OCP class names. |
@jancborchardt I don't think its possible to put this in the core? Maybe as an application which you can enable and is already delivered in the core version? |
@webbakery We already have previews in ownCloud 6. There is already soft dependency on imagick for creating previews of pdf, office and svg files. Illustrator and Photoshop previews are quite easy to implement. I am just not sure if Illustrator is important enough to be shipped with core. |
@georgehrke In my own opinion: I would think it's just great to offer a preview for any extension. Maybe with an option to select the different extensions which you want to convert? BTW: Any thoughts on converting large psd-files? Like around 1GB? Runs smooth enough? And if psd files are easy to implement, is there also an option for psb-format? |
Previews are generated on demand. If you open a directory with files, for which no thumbnail was generated yet, it will be generated. Crons are kind of problematic, because it's not available everywhere, so ownCloud can't depend on it.
It depends on whether or not imagemagick supports psb.
That's definitely something that has to be discussed. I'd personally say to not generate previews for (psd-)files bigger than 1GB. |
PSD and Illustrator, being largely popular image files, are definitely fit for adding to core. Introducing modules which are only available in the app store just for that seems a bit strange. Especially since we already have the soft-dependency on imagemagick. |
@georgehrke Isn't it possible to keep the extension of the files in the database? And if the server is idle, or within a certain of time, it finishes converting the wanted documents (which you can enable in the one application added to owncloud which holds all converting options). It's especially handy for large files, for small files this is just an extra but doesn't really have any value, no? @jancborchardt Let me figure out what all of the functionality's are of imagemagick. Can't we enable them all? Everyone has specific needs. I don't need them all and I certainly think nobody does, but some people need to convert pdf to jpg, others pdf and ai to jpg, .... |
ownCloud is written in PHP. This means that it runs when you call it (open it in the browser, access it via webdav). There is no daemon running 24/7. This problem is partly solvable by cron jobs, but we don't want a hard dependency on cron jobs.
There is lazy loading. Previews are being generated once the page was loaded. |
@georgehrke It's not necessary to depend on cron-jobs, but it certainly would be a nice feature for the people who want to use it like this? That sounds more convenient if you say it like that, stupid of me to actually think otherwise ... |
From my experience with It's not too difficult to add support for new formats, but PSD and AI files have layers and getting consistent results may require quite a bit of tuning. Also, regarding memory, I don't know if you'll run into the same limitations, but Imagick/PHP wanted close to 1GB of memory to convert a 90MB TIFF file... |
Hi, I don't understand everything, but I need to have a thumbnail for Adobe files, specifically for .ai files. It is possible? Thanks, Owncloud user. |
I'm not working on this, no, but anybody who can read PHP can duplicate my effort. It should be a 30-60 minutes effort. |
According to BountySource, nobody is that interested, but I've submitted a PR which should make it much, much easier in the future to add new formats supported by Imagemagick. The gallery app needs some internal changes in order to support the new formats, but it works rather well. |
Merged. Thumbnails will be generated for .ai, .eps, .ps and .psd. |
Feature request:
Create thumbnails of .ai & .psd file's with imagemagick.
Or with even more options of auto-converting?
It would also be nice to create thumbs of .pdf-files which are larger then ...MB to quickly preview them if you click on it.
The text was updated successfully, but these errors were encountered: