Bitmap class to handle all Imagick conversions to bitmap

[oparoz]

As I was considering more formats to play with, I quickly realised that the process was always the same. Imagick does a good job out of the box to properly convert files to bitmaps.

I'm always targeting the layer 0 of the file to convert as it's the one which either contains the first page, the only image or a flattened representation of a document.

Bitmap is in the name of the class because I can see a separate class being created for people who have an improved version of Imagemagick and who want to generate SVGs

And finally, .psd, .ai and .eps support have been added.

[ghost]

Thanks a lot for your contribution! Contributions to the core repo require a signed contributors agreement http://owncloud.org/contribute/agreement/ Alternatively you can add a comment here stating that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

[oparoz]

This contribution is MIT licensed

[MorrisJobke]

Too much intendation

[oparoz]

Fixed, sorry about that.

[MorrisJobke]

cc @georgehrke

[georgehrke]

code looks good,
to test:

• PDF is still working
• TIFF is still working
• Illustrator is working
• Postscript is working
• Photoshop is working

[georgehrke]

ps is also a very common extension for postscript files

[oparoz]

Yeah, just thought of that. I'm updating the list of mimetypes as we speak.

[georgehrke]

I don't have any Photoshot or Illustrator file to test.
@MorrisJobke Do you have any psd/ai files to test this?

[oparoz]

PSD file http://mauricioestrella.deviantart.com/art/Cassette-PSD-File-86548493

(The full screen preview with the fixed gallery looks good with that one :))

[oparoz]

For AI
http://all-free-download.com/free-vector/vector-misc/green_eco_friendly_badge_311432.html

[georgehrke]

@oparoz Thx for the links
Both, pdf and ai, are working fine. :)

• please squash

👍 afterwords

[oparoz]

I wished Github would let me... I'm going to have to create a new branch again.

[georgehrke]

after squashing you have to push --force

[oparoz]

That worked! \o/ Thanks for the tip, the cli works better than their GUI...

[scrutinizer-notifier]

The inspection completed: 5 new issues, 9 updated code elements

[MorrisJobke]

Works nice! 👍 Thanks!

And welcome as a ownCloud contributor :)

[MorrisJobke]

Feel free to also join the IRC channel #owncloud-dev on freenode

[oparoz]

Ah, thanks for the channel. Could come in handy before doing some mods :)