Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create groups with special characters #82

Closed
MTRichards opened this issue Oct 24, 2012 · 2 comments
Closed

Cannot create groups with special characters #82

MTRichards opened this issue Oct 24, 2012 · 2 comments
Assignees
Milestone

Comments

@MTRichards
Copy link
Contributor

When creating users/groups in owncloud 4.5, can't create groups with any special characters (), for example, doesn't work. It allows you to create them in javascript, but then when you reload the page, they disappear - even if you assigned them to a user.

Better experience would be to allow special characters in group names. Second best would be to disallow special characters in the creation of groups.

@LukasReschke
Copy link
Member

The reason for this is the limitation in lib/group.php:

public static function createGroup( $gid ) {
        // Check the name for bad characters
        // Allowed are: "a-z", "A-Z", "0-9" and "_.@-"
        if( preg_match( '/[^a-zA-Z0-9 _\.@\-]/', $gid )) {
            return false;
        }

This was introduced with b37fb91 by @jakobsack - it would be appreciated if someone else could check if this is needed here. If yes, we should clearly include a check in the JS.

@ghost ghost assigned LukasReschke Oct 24, 2012
LukasReschke added a commit that referenced this issue Oct 25, 2012
@LukasReschke
Copy link
Member

As I don't think it would cause any problems to allow any characters here, I removed the check.

aditmeno pushed a commit to aditmeno/Aeolus that referenced this issue Apr 2, 2015
PhpZipStream updated to work properly on php 5.3 - see https://github.co...
@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants